From 132047f2dff9749df7b8b35395659bb3a0681801 Mon Sep 17 00:00:00 2001 From: Eli Heuer Date: Wed, 13 Oct 2021 11:19:46 -0700 Subject: [PATCH 1/2] Adjust typoDescender formula so result is a negative number --- VerticalMetrics/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VerticalMetrics/README.md b/VerticalMetrics/README.md index de57a13..7e9cdad 100644 --- a/VerticalMetrics/README.md +++ b/VerticalMetrics/README.md @@ -121,7 +121,7 @@ A new Latin family has the following qualities: 1. Set the default values, following the schema above: - typoAscender = `965`. (`UPM * 1.2 - CapsHeight) / 2 + CapsHeight` which is greater than Agrave, perfect.) - - typoDescender = `-235`. (`UPM * 1.2 - CapsHeight) / 2` which is equal to deepest letterform) + - typoDescender = `-235`. (`UPM * 1.2 - CapsHeight) / -2` which is equal to deepest letterform) - typoLineGap = `0` - hheaAscender = `965` (typoAscender) - hheaDescender = `-235` (typoDescender) From 409887ebfa2490600dfe8cc19feb214a0fb4aa71 Mon Sep 17 00:00:00 2001 From: Eli Heuer Date: Mon, 18 Oct 2021 10:44:34 -0700 Subject: [PATCH 2/2] Update vertical metrics formula based on marc's feedback --- VerticalMetrics/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/VerticalMetrics/README.md b/VerticalMetrics/README.md index 7e9cdad..ee4a136 100644 --- a/VerticalMetrics/README.md +++ b/VerticalMetrics/README.md @@ -120,8 +120,8 @@ A new Latin family has the following qualities: 1. Set the default values, following the schema above: - - typoAscender = `965`. (`UPM * 1.2 - CapsHeight) / 2 + CapsHeight` which is greater than Agrave, perfect.) - - typoDescender = `-235`. (`UPM * 1.2 - CapsHeight) / -2` which is equal to deepest letterform) + - typoAscender = `965` (`(UPM * 1.2 - CapsHeight) / 2 + CapsHeight` which is greater than Agrave, perfect.) + - typoDescender = `-235` (`-(UPM * 1.2 - CapsHeight) / 2` which is equal to deepest letterform) - typoLineGap = `0` - hheaAscender = `965` (typoAscender) - hheaDescender = `-235` (typoDescender)