chore(vars): using go testing entities for test helpers #785
+11
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This pull request refactors the
SetURLVarstest helper to improve testing practices and updates its usage in tests. The main focus is to enhance test reliability by leveraging Go'stesting.Thelper methods and to update the relevant test case accordingly.Test helper improvements:
SetURLVarsfunction intest_helpers.goto accept a*testing.Tparameter and callt.Helper(), improving error reporting and aligning with Go testing conventions.test_helpers.goto support the new parameter.Test case updates:
ExampleSetURLVarsexample function inmux_test.gowith a proper test functionTestExampleSetURLVarsthat uses the updatedSetURLVarshelper and asserts the expected value usingt.Errorf.Added/updated tests?
have not been included
Run verifications and test
make verifyis passingmake testis passing