Comment related changes

Author: dborovic

src/WebApiTestApplication/Scripts/Endpoints/Service.ts

@@ -21,15 +21,17 @@ namespace Endpoints {
         }
 
         static callCached<TView>(endpoint: IEndpoint, data) {
-            if (this.endpointCache[endpoint.toString()] == null) {
-                return this.call(endpoint, data).then(result => {
-                    this.endpointCache[endpoint.toString()] = result;
-                    return this.endpointCache[endpoint.toString()];
+            var cacheKey = endpoint.toString();
+        
+            if (this.endpointCache[cacheKey] == null) {
+                return this.call<TView>(endpoint, data).then(result => {
+                    this.endpointCache[cacheKey] = result;
+                    return this.endpointCache[cacheKey];
                 });
             }
 
             const deferred = this.$q.defer();
-            deferred.resolve(this.endpointCache[endpoint.toString()]);
+            deferred.resolve(this.endpointCache[cacheKey]);
             return deferred.promise;
         }
 

src/WebApiToTypeScript/Config/Config.cs

@@ -13,7 +13,7 @@ public class Config
             = "Endpoints";
 
         public bool EndpointsSupportCaching { get; set; }
-            = true;
+            = false;
 
         public string EndpointsFileName { get; set; }
             = "Endpoints.ts";

src/WebApiToTypeScript/Endpoints/AngularEndpointsService.cs

@@ -31,17 +31,18 @@ public TypeScriptBlock CreateServiceBlock()
                 serviceBlock
                     .Parent
                     .AddAndUseBlock("static callCached<TView>(endpoint: IEndpoint, data)")
-                    .AddAndUseBlock("if (this.endpointCache[endpoint.toString()] == null)")
-                    .AddAndUseBlock("return this.call(endpoint, data).then(result =>", isFunctionBlock: true,
+                    .AddStatement("var cacheKey = endpoint.toString();")
+                    .AddAndUseBlock("if (this.endpointCache[cacheKey] == null)")
+                    .AddAndUseBlock("return this.call<TView>(endpoint, data).then(result =>", isFunctionBlock: true,
                         terminationString: ";")
-                    .AddStatement("this.endpointCache[endpoint.toString()] = result;")
-                    .AddStatement("return this.endpointCache[endpoint.toString()];")
+                    .AddStatement("this.endpointCache[cacheKey] = result;")
+                    .AddStatement("return this.endpointCache[cacheKey];")
                     .Parent
                     .Parent
                     .AddStatement("const deferred = this.$q.defer();")
-                    .AddStatement("deferred.resolve(this.endpointCache[endpoint.toString()]);")
+                    .AddStatement("deferred.resolve(this.endpointCache[cacheKey]);")
                     .AddStatement("return deferred.promise;");
-            
+
             return serviceBlock
                     .Parent
                     .Parent;
@@ -94,11 +95,11 @@ public void WriteServiceObjectToBlock(TypeScriptBlock serviceBlock, WebApiContro
                     var endpointFullName = $"{Config.EndpointsNamespace}.{webApiController.Name}.{actionName}";
 
                     var cachedBlock = Config.EndpointsSupportCaching &&
-                                      string.Equals(verb.Verb, "GET", StringComparison.InvariantCultureIgnoreCase)
+                                      string.Equals(verb.Verb, WebApiHttpVerb.Get.Verb, StringComparison.InvariantCultureIgnoreCase)
                         ? new TypeScriptBlock()
                             .AddAndUseBlock($"callCached<TView>({callArgumentDefinition})")
                             .AddStatement($"return {Config.ServiceName}.callCached<TView>(this, {callArgumentValue});")
-                        : null; 
+                        : null;
 
                     controllerBlock
                         .AddAndUseBlock

src/WebApiToTypeScript/Endpoints/EndpointsService.cs

@@ -121,7 +121,7 @@ private void WriteInterfaceWithCallToBlock(TypeScriptBlock interfaceWithCallBloc
             interfaceWithCallBlock
                 .AddStatement($"call<TView>({callArgumentsList}): ng.IPromise<TView>;");
 
-            if (Config.EndpointsSupportCaching && string.Equals(verb.Verb, "GET", StringComparison.InvariantCultureIgnoreCase))
+            if (Config.EndpointsSupportCaching && string.Equals(verb.Verb, WebApiHttpVerb.Get.Verb, StringComparison.InvariantCultureIgnoreCase))
                 interfaceWithCallBlock
                     .AddStatement($"callCached<TView>({callArgumentsList}): ng.IPromise<TView>;");
         }