From 70fde431cad58a99f88b52c4fea71259345ebd4a Mon Sep 17 00:00:00 2001
From: MaysWind <i@mayswind.net>
Date: Sun, 20 May 2018 22:25:09 +0800
Subject: [PATCH 1/4] add disabled parameter, only show non-empty dropdown
 parameter, and valueChanged callback.

---
 README.md        |  3 +++
 inputDropdown.js | 24 ++++++++++++++++++++++--
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 789c647..0f37967 100644
--- a/README.md
+++ b/README.md
@@ -80,10 +80,13 @@ These attributes are available to set on the `<input-dropdown>` directive.
 * `input-class-name`: String. Sets the classname for the input element - e.g. form-control for bootstrap
 * `input-name`: String. Sets the name attribute on the input element
 * `input-required`: Boolean. Sets ng-required on the input element. If true the input will validate when the user has made a selection from the dropdown list.
+* `disabled`: Boolean. Sets ng-disabled on the input element
 * `selected-item`: Object, *required*. Used in the controller to read the user's selection. Can be set to null when created or equal to an item in the dropdown array to set the initial value for the input. Will update when the user selects an item from the list.
 * `default-dropdown-items`: Array. An array of strings or object to show in the dropdown list. If objects, each object must have a property `readableName` which is what will show in the dropdown. If not set there will be no default list when the input field is empty and you'll need to pass a list based on the users input in the `filter-list-method`.
+* `only-show-non-empty-dropdown`: Boolean. If not set or set to false there will show dropdown always even though the dropdown has no item.
 * `filter-list-method`: Function. Called when user types in the input field. Must return a promise that resolves with an array to use as a new dropdown list. Must be set with a `userInput` paramater: `filter-list-method="methodToCall(userInput)"`.
 * `item-selected-method`: Function. Called when user selects an item from the dropdown. Must be set with an `item` paramater: `item-selected-method="methodToCall(item)"`.
+* `value-changed-method`: Function. Called when user changes text in the input field or selects an item from the dropdown. The function can be set with `value` and `from` parameters: `value-changed-method="methodToCall(value, from)"`.
 * `allow-custom-input`: Boolean. Set to true to let user enter their own value instead of forcing an item from the dropdown list to be selected.
 
 ### Custom user input
diff --git a/inputDropdown.js b/inputDropdown.js
index cb756b9..4ab8206 100644
--- a/inputDropdown.js
+++ b/inputDropdown.js
@@ -6,11 +6,12 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
            'placeholder="{{inputPlaceholder}}"' +
            'autocomplete="off"' +
            'ng-model="inputValue"' +
-           'class="{{inputClassName}}"' + 
+           'class="{{inputClassName}}"' +
            'ng-required="inputRequired"' +
            'ng-change="inputChange()"' +
            'ng-focus="inputFocus()"' +
            'ng-blur="inputBlur($event)"' +
+           'ng-disabled="disabled"' +
            'input-dropdown-validator>' +
      '<ul ng-show="dropdownVisible">' +
       '<li ng-repeat="item in dropdownItems"' +
@@ -32,10 +33,13 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
       selectedItem: '=',
       allowCustomInput: '=',
       inputRequired: '=',
+      disabled: '=',
       inputName: '@',
       inputClassName: '@',
       inputPlaceholder: '@',
+      onlyShowNonEmptyDropdownItems: '@',
       filterListMethod: '&',
+      valueChangedMethod: '&',
       itemSelectedMethod: '&'
     },
     template: templateString,
@@ -108,6 +112,8 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
         scope.selectedItem = null;
         showDropdown();
 
+        fireValueChangedEvent(scope.inputValue, 'input');
+
         if (!scope.inputValue) {
           scope.dropdownItems = scope.defaultDropdownItems || [];
           return;
@@ -154,12 +160,17 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
         hideDropdown();
         scope.dropdownItems = [item];
 
+        fireValueChangedEvent(item, 'select');
+
         if (scope.itemSelectedMethod) {
           scope.itemSelectedMethod({item: item});
         }
       };
 
       var showDropdown = function () {
+        if (scope.onlyShowNonEmptyDropdownItems && !(scope.dropdownItems && scope.dropdownItems.length)) {
+          return;
+        }
         scope.dropdownVisible = true;
       };
       var hideDropdown = function() {
@@ -192,6 +203,15 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
         }
       };
 
+      var fireValueChangedEvent = function(value, from) {
+        if (scope.valueChangedMethod) {
+          scope.valueChangedMethod({
+            value: value,
+            from: from
+          })
+        }
+      };
+
       element.bind("keydown keypress", function (event) {
         switch (event.which) {
           case 38: //up
@@ -208,7 +228,7 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
             }
             break;
           case 9: // tab
-            if (scope.dropdownVisible && scope.dropdownItems && scope.dropdownItems.length > 0 && scope.activeItemIndex !== -1) {              
+            if (scope.dropdownVisible && scope.dropdownItems && scope.dropdownItems.length > 0 && scope.activeItemIndex !== -1) {
               scope.$apply(selectActiveItem);
             }
             break;

From e13100b407c409d34906e02c03952ab1ab96612a Mon Sep 17 00:00:00 2001
From: MaysWind <i@mayswind.net>
Date: Sun, 20 May 2018 22:51:47 +0800
Subject: [PATCH 2/4] modify parameter name

---
 inputDropdown.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/inputDropdown.js b/inputDropdown.js
index 4ab8206..0998ee1 100644
--- a/inputDropdown.js
+++ b/inputDropdown.js
@@ -37,7 +37,7 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
       inputName: '@',
       inputClassName: '@',
       inputPlaceholder: '@',
-      onlyShowNonEmptyDropdownItems: '@',
+      onlyShowNonEmptyDropdown: '@',
       filterListMethod: '&',
       valueChangedMethod: '&',
       itemSelectedMethod: '&'
@@ -168,7 +168,7 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
       };
 
       var showDropdown = function () {
-        if (scope.onlyShowNonEmptyDropdownItems && !(scope.dropdownItems && scope.dropdownItems.length)) {
+        if (scope.onlyShowNonEmptyDropdown && !(scope.dropdownItems && scope.dropdownItems.length)) {
           return;
         }
         scope.dropdownVisible = true;

From 33e48a818215b9d582f5db8d3b59fce4ed6b92c7 Mon Sep 17 00:00:00 2001
From: mayswind <i@mayswind.net>
Date: Sun, 8 Jul 2018 21:37:27 +0800
Subject: [PATCH 3/4] Update inputDropdown.js

hide dropdown list when dropdown list has no item
---
 inputDropdown.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/inputDropdown.js b/inputDropdown.js
index 0998ee1..6f50a5e 100644
--- a/inputDropdown.js
+++ b/inputDropdown.js
@@ -13,7 +13,7 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
            'ng-blur="inputBlur($event)"' +
            'ng-disabled="disabled"' +
            'input-dropdown-validator>' +
-     '<ul ng-show="dropdownVisible">' +
+     '<ul ng-show="dropdownVisible && dropdownItems && dropdownItems.length">' +
       '<li ng-repeat="item in dropdownItems"' +
           'ng-click="selectItem(item)"' +
           'ng-mouseenter="setActive($index)"' +

From 68670e39816698b3eb98c0e740a0efe77d5fbdd1 Mon Sep 17 00:00:00 2001
From: MaysWind <i@mayswind.net>
Date: Sun, 8 Jul 2018 22:42:57 +0800
Subject: [PATCH 4/4] fix injection bug

---
 inputDropdown.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/inputDropdown.js b/inputDropdown.js
index 6f50a5e..801a76b 100644
--- a/inputDropdown.js
+++ b/inputDropdown.js
@@ -43,7 +43,7 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
       itemSelectedMethod: '&'
     },
     template: templateString,
-    controller: function($scope) {
+    controller: ["$scope", function($scope) {
       this.getSelectedItem = function() {
         return $scope.selectedItem;
       };
@@ -56,7 +56,7 @@ angular.module('inputDropdown', []).directive('inputDropdown', [function() {
       this.getInput = function() {
         return $scope.inputValue;
       };
-    },
+    }],
     link: function(scope, element) {
       var pressedDropdown = false;
       var inputScope = element.find('input').isolateScope();