Incompatibilities with `-f-text`

[sjakobi]

prettyprinter-compat-wl-pprint:

src/Text/PrettyPrint/Leijen.hs:181:20: error: [GHC-76037]
    Not in scope: ‘NewT.renderLazy’
    Note: The module ‘Prettyprinter.Render.Text’ does not export ‘renderLazy’.
    Suggested fix:
      Perhaps use ‘NewT.renderIO’ (imported from Prettyprinter.Render.Text)
    |
181 |     let rendered = NewT.renderLazy sdoc
    |                    ^^^^^^^^^^^^^^^

prettyprinter-compat-annotated-wl-pprint:

src/Text/PrettyPrint/Annotated/Leijen.hs:115:76: error: [GHC-83865]
    • Couldn't match type ‘[Char]’ with ‘T.Text’
      Expected: T.Text
        Actual: prettyprinter-1.7.1:Data.Text.Text
    • In the first argument of ‘T.unpack’, namely ‘str’
      In the first argument of ‘showString’, namely ‘(T.unpack str)’
      In the second argument of ‘(.)’, namely ‘showString (T.unpack str)’
    |
115 |     go s d stk             (SText _ str x)  = go (s . showString (T.unpack str)) d stk x
    |                                                                            ^^^

src/Text/PrettyPrint/Annotated/Leijen.hs:131:51: error: [GHC-83865]
    • Couldn't match type ‘[Char]’ with ‘T.Text’
      Expected: T.Text
        Actual: prettyprinter-1.7.1:Data.Text.Text
    • In the first argument of ‘T.unpack’, namely ‘s’
      In the first argument of ‘str’, namely ‘(T.unpack s)’
      In the first argument of ‘(<++>)’, namely ‘str (T.unpack s)’
    |
131 |     go stk       (SText _ s x)    = str (T.unpack s) <++> go stk x
    |                                                   ^

src/Text/PrettyPrint/Annotated/Leijen.hs:152:65: error: [GHC-83865]
    • Couldn't match type ‘[Char]’ with ‘T.Text’
      Expected: T.Text
        Actual: prettyprinter-1.7.1:Data.Text.Text
    • In the first argument of ‘T.unpack’, namely ‘s’
      In the expression: T.unpack s
      In the first argument of ‘mapFst’, namely ‘(T.unpack s ++)’
    |
152 |     go i stk                (SText l s x)    = mapFst (T.unpack s ++) (go (i + l) stk x)
    |                                                                 ^

src/Text/PrettyPrint/Annotated/Leijen.hs:174:38: error: [GHC-83865]
    • Couldn't match type ‘[Char]’ with ‘T.Text’
      Expected: T.Text
        Actual: prettyprinter-1.7.1:Data.Text.Text
    • In the second argument of ‘T.hPutStr’, namely ‘s’
      In the first argument of ‘(>>)’, namely ‘T.hPutStr h s’
      In the expression: T.hPutStr h s >> go x
    |
174 |      go (SText _ s x)  = T.hPutStr h s >> go x
    |                                      ^

prettyprinter-ansi-terminal:

src/Prettyprinter/Render/Terminal/Internal.hs:158:44: error: [GHC-83865]
    • Couldn't match type ‘[Char]’ with ‘Text’
      Expected: Text
        Actual: prettyprinter-1.7.1:Data.Text.Text
    • In the first argument of ‘TLB.fromText’, namely ‘t’
      In the first argument of ‘(<>)’, namely ‘TLB.fromText t’
      In the expression: TLB.fromText t <> go s rest
    |
158 |             SText _ t rest -> TLB.fromText t <> go s rest
    |                                            ^

src/Prettyprinter/Render/Terminal/Internal.hs:211:29: error: [GHC-83865]
    • Couldn't match type ‘[Char]’ with ‘Text’
      Expected: Text
        Actual: prettyprinter-1.7.1:Data.Text.Text
    • In the second argument of ‘T.hPutStr’, namely ‘t’
      In a stmt of a 'do' block: T.hPutStr h t
      In the expression:
        do T.hPutStr h t
           go rest
    |
211 |                 T.hPutStr h t
    |                             ^

[sjakobi]

As a stop-gap measure I've made the text flag a manual flag, just to fix CI:

https://github.com/quchen/prettyprinter/pull/263/files#diff-2c5963c6ab1eab7a02da137305479c8cf31084add513b958f706a235a4f33eea

I would have preferred to express that the incompatible packages require prettyprinter +text. I suspect this still isn't possible in .cabal files (https://stackoverflow.com/questions/23523869/is-there-any-way-to-define-flags-for-cabal-dependencies says no). Do you happen to know, @Bodigrim?

I actually don't see a way to configure -ftext for haskell-ci. 🤷‍♂️

Maybe we should just stop using it then… :|

[sjakobi]

There's also the question whether the text flag is actually still needed and useful. optparse-applicative apparently requires text now, so maybe we can simply remove this hack?!

[a-02]

I agree, don't really see a reason why text can't be an always needed build dependency.

[sjakobi]

@Bodigrim, since you proposed and implemented this flag back in #202, it would be great to get your input on this. Do you know whether anyone is still relying on its existence? Is it still useful at all?