GitHub Action doesn't respect Pull Requests and it's branches while validating.

[AL2009man]

It appears that GitHub Action on the .yml validate doesn't include something like this:

on:
  pull_request:
    branches:
      - main
    types:
      - edited
      - opened
      - synchronize

While it's fine for releases, Git Actions will instead use main as opposed to using the pull request's changes for testing purposes.

This caused several hours of troubleshooting when trying to test the changes before merging to Master. Had to resort to building the file myself due to it.

[dcvz]

@AL2009man which of your PR's had this issue? For PR's that come from the outside only the yaml worklflow from main is used. So if your changes were there, then yes, they won't be taken into account. This is the workflow that fires for external PRs: https://github.com/hedge-dev/UnleashedRecomp/blob/main/.github/workflows/validate-external.yml

[AL2009man]

@AL2009man which of your PR's had this issue? For PR's that come from the outside only the yaml worklflow from main is used. So if your changes were there, then yes, they won't be taken into account. This is the workflow that fires for external PRs: https://github.com/hedge-dev/UnleashedRecomp/blob/main/.github/workflows/validate-external.yml

Specifically, it's this one. #1086 (and potentially the rest of my PR,)

Whenever GitHub Action files gets uploaded and be able to download it for testing, it doesn't seem to pick up my changes, at all. Meanwhile, my compiled build is able to pick up those changes no problem.

I've been trying to troubleshoot if it's something to do with my current fork repository (something got broken during the initial troubleshooting) or is this projects' way of doing PR Pulls isn't working.

[blueskythlikesclouds]

Why did you close? This is still a problem.