TestUserAgentHeaderInK8sRESTClientConfig appears to fail when you have a bad .kube/config

[TerryHowe]

TestUserAgentHeaderInK8sRESTClientConfig appears to fail when you have a bad .kube/config

In my case, current context was no longer a valid cluster.

Ideally the unit tests wouldn't rely on the current k8s environment.

[benoittgt]

I think we have something similar with plugins. #30614 (comment)

[artemmikhalitsin]

@benoittgt
Specifically, its an issue with this test
https://github.com/helm/helm/blob/main/pkg/cmd/plugin_test.go#L331-L333

but not this one
https://github.com/helm/helm/blob/main/pkg/cmd/plugin_test.go#L400-L402

Not sure what the discrepancy is, and did not really dig much into it

@TerryHowe
I 100% agree and would upgrade your "wouldn't" to "mustn't"

[LarytheLord]

I’m working on this. I’m making TestUserAgentHeaderInK8sRESTClientConfig hermetic by using a temporary kubeconfig in the test instead of whatever is on the host machine.

[LarytheLord]

Opened PR #31907 to make TestUserAgentHeaderInK8sRESTClientConfig use a temporary kubeconfig, so it doesn't depend on host .kube/config state.