chore(vite-plus): 🔧 update installation instructions for devcontainer user

- clarify installation path for Vite+ CLI in README
- modify devcontainer-feature.json description for clarity
- enhance install.sh to ensure per-user installation
- simplify test.sh to check for vp CLI availability

Author: baxyz

src/vite-plus/README.md

@@ -47,7 +47,7 @@ Add this feature to your `devcontainer.json`:
 ```
 
 This will:
-1. Install `vp` (Vite+ unified CLI) globally
+1. Install `vp` (Vite+ unified CLI) for the devcontainer user
 2. Install Oxc and Vitest VS Code extensions
 3. Configure Oxc as the default formatter
 4. Enable format-on-save and auto-fix
@@ -76,7 +76,7 @@ If you prefer standalone tools instead of or alongside `vp`:
 
 | Option | Type | Default | Description |
 |--------|------|---------|-------------|
-| `installVitePlus` | boolean | `true` | Install Vite+ unified CLI (`vp`) via the official installer |
+| `installVitePlus` | boolean | `true` | Install Vite+ unified CLI (`vp`) for the devcontainer user (`~/.vite-plus/bin`) |
 | `installVite` | boolean | `false` | Install standalone Vite CLI via npm (not needed with `vp`) |
 | `installVitest` | boolean | `false` | Install standalone Vitest CLI via npm (not needed with `vp`) |
 | `installOxc` | boolean | `false` | Install Oxc language server via npm (not needed with `vp`) |

src/vite-plus/devcontainer-feature.json

@@ -8,7 +8,7 @@
     "installVitePlus": {
       "type": "boolean",
       "default": true,
-      "description": "Install Vite+ unified CLI (vp) globally via the official installer"
+      "description": "Install Vite+ unified CLI (vp) for the devcontainer user (~/.vite-plus/bin)"
     },
     "installVite": {
       "type": "boolean",

src/vite-plus/install.sh

@@ -34,6 +34,25 @@ if [ "$USERNAME" = "automatic" ] || [ "$USERNAME" = "root" ]; then
     fi
 fi
 
+# Ensure apt is in non-interactive mode
+export DEBIAN_FRONTEND=noninteractive
+
+# Update apt if needed
+apt_get_update() {
+    if [ "$(find /var/lib/apt/lists/* | wc -l)" = "0" ]; then
+        echo "Running apt-get update..."
+        apt-get update -y
+    fi
+}
+
+# Check and install packages
+check_packages() {
+    if ! dpkg -s "$@" > /dev/null 2>&1; then
+        apt_get_update
+        apt-get -y install --no-install-recommends "$@"
+    fi
+}
+
 # Check if node/npm is available (needed for fallback tools and npm-based installs)
 if ! command -v npm >/dev/null 2>&1; then
     echo "❌ npm not found. Please ensure Node.js feature is installed first."
@@ -44,30 +63,55 @@ fi
 if [ "$INSTALL_VITE_PLUS" = "true" ]; then
     echo "📦 Installing Vite+ unified CLI (vp) via official installer..."
 
-    # Install vp using the official installer
-    if curl -fsSL https://vite.plus | bash 2>/dev/null; then
-        echo "✅ Vite+ CLI (vp) installed"
-
-        # Source environment to make vp available
-        VP_HOME="${HOME}/.vite-plus"
-        if [ -d "$VP_HOME" ]; then
-            export PATH="${VP_HOME}/bin:${PATH}"
-        fi
+    # Ensure curl and ca-certificates are available
+    check_packages curl ca-certificates
 
-        # Also install for the non-root user if different
-        if [ "$USERNAME" != "root" ]; then
-            su - "$USERNAME" -c 'curl -fsSL https://vite.plus | bash' 2>/dev/null || true
-        fi
+    # Download installer to a temp file to avoid pipefail issues
+    INSTALLER_SCRIPT=$(mktemp)
+    trap 'rm -f "$INSTALLER_SCRIPT"' EXIT
 
-        # Verify installation
-        if command -v vp >/dev/null 2>&1; then
-            VP_VERSION=$(vp --version 2>/dev/null || echo "unknown")
-            echo "   Version: ${VP_VERSION}"
+    if ! curl -fsSL https://vite.plus -o "$INSTALLER_SCRIPT"; then
+        echo "❌ Failed to download Vite+ installer."
+        exit 1
+    fi
+    chmod 644 "$INSTALLER_SCRIPT"
+
+    # Install vp for the devcontainer user (per-user install in ~/.vite-plus/bin)
+    if [ "$USERNAME" != "root" ]; then
+        if su - "$USERNAME" -c "bash '$INSTALLER_SCRIPT'"; then
+            USER_HOME=$(eval echo "~${USERNAME}")
+            USER_VP_HOME="${USER_HOME}/.vite-plus"
+            if [ -d "$USER_VP_HOME" ]; then
+                echo "✅ Vite+ CLI (vp) installed at ${USER_VP_HOME}/bin"
+            fi
+
+            # Verify vp is available for the user
+            if su - "$USERNAME" -c 'command -v vp' >/dev/null 2>&1; then
+                VP_VERSION=$(su - "$USERNAME" -c 'vp --version 2>/dev/null' || echo "unknown")
+                echo "   Version: ${VP_VERSION}"
+            else
+                echo "   vp installed, will be available in new shell sessions for ${USERNAME}"
+            fi
         else
-            echo "   vp installed, will be available in new shell sessions"
+            echo "❌ Failed to install Vite+ CLI via official installer."
+            exit 1
         fi
     else
-        echo "⚠️  Failed to install Vite+ CLI via official installer, but continuing..."
+        # Root-only fallback
+        if bash "$INSTALLER_SCRIPT"; then
+            echo "✅ Vite+ CLI (vp) installed"
+            VP_HOME="${HOME}/.vite-plus"
+            if [ -d "$VP_HOME" ]; then
+                export PATH="${VP_HOME}/bin:${PATH}"
+            fi
+            if command -v vp >/dev/null 2>&1; then
+                VP_VERSION=$(vp --version 2>/dev/null || echo "unknown")
+                echo "   Version: ${VP_VERSION}"
+            fi
+        else
+            echo "❌ Failed to install Vite+ CLI via official installer."
+            exit 1
+        fi
     fi
 fi
 

test/vite-plus/test.sh

@@ -17,14 +17,9 @@ check "node is available" command -v node
 check "npm is available" command -v npm
 
 # Check vp (Vite+ unified CLI) installation
-if command -v vp >/dev/null 2>&1; then
-    check "vp CLI is available" command -v vp
-    check "vp version displays" vp --version
-elif [ -f "${HOME}/.vite-plus/bin/vp" ]; then
-    check "vp binary exists in ~/.vite-plus/bin" test -f "${HOME}/.vite-plus/bin/vp"
-else
-    echo "⚠️  vp CLI not found (installVitePlus=false or installer path not in PATH)"
-fi
+# vp is required by default (installVitePlus=true), so this must pass
+check "vp CLI is available" command -v vp
+check "vp version displays" vp --version
 
 # Check standalone Vite CLI (optional, not needed with vp)
 if command -v vite >/dev/null 2>&1; then