Skip to content

Commit aa0e9f0

Browse files
feat: Add Acceptance Criteria to Good First Issue Template (#997) (#998)
Signed-off-by: Aditya <adityashirsatrao007@gmail.com> Signed-off-by: Aditya Shirsat <adityashirsatrao007@gmail.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@users.noreply.github.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
1 parent 2ffeae5 commit aa0e9f0

File tree

2 files changed

+23
-3
lines changed

2 files changed

+23
-3
lines changed

.github/ISSUE_TEMPLATE/01_good_first_issue.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,22 @@ body:
179179
associate_token_with_account(client, token_id, account_id, account_private_key)
180180
```
181181
182+
- type: textarea
183+
id: acceptance-criteria
184+
attributes:
185+
label: ✅ Acceptance Criteria
186+
description: |
187+
EDIT OR EXPAND THE CHECKLIST ON WHAT IS REQUIRED TO BE ABLE TO MERGE A PULL REQUEST FOR THIS ISSUE
188+
value: |
189+
To be able to merge a pull request for this issue, we need:
190+
- [ ] **Changelog Entry:** Correct changelog entry (please link to the documentation - [see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/changelog_entry.md))
191+
- [ ] **Signed commits:** commits must be DCO and GPG key signed ([see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/signing.md))
192+
- [ ] **All Tests Pass:** our workflow checks like unit and integration tests must pass
193+
- [ ] **Issue is Solved:** The implementation fully addresses the issue requirements as described above
194+
- [ ] **No Further Changes are Made:** Code review feedback has been addressed and no further changes are requested
195+
validations:
196+
required: true
197+
182198
- type: textarea
183199
id: contribution_steps
184200
attributes:

CHANGELOG.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Changelog
1+
# Changelog
22

33
All notable changes to this project will be documented in this file.
44
This project adheres to [Semantic Versioning](https://semver.org).
@@ -7,20 +7,24 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
77
## [Unreleased]
88

99
### Added
10-
- Added __str__() to CustomFixedFee and updated examples and tests accordingly.
10+
11+
- Added **str**() to CustomFixedFee and updated examples and tests accordingly.
1112
- Added a github template for good first issues
1213
- Added `.github/workflows/bot-assignment-check.yml` to limit non-maintainers to 2 concurrent issue assignments.
13-
- Added all missing fields to __str__() method and updated `test_tokem_info.py`
14+
- Added all missing fields to **str**() method and updated `test_tokem_info.py`
1415
- Add examples/tokens/token_create_transaction_pause_key.py example demonstrating token pause/unpause behavior and pause key usage (#833)
1516
- Added `docs/sdk_developers/training/transaction_lifecycle.md` to explain the typical lifecycle of executing a transaction using the Hedera Python SDK.
1617
- Add inactivity bot workflow to unassign stale issue assignees (#952)
1718
- Made custom fraction fee end to end
19+
- Added Acceptance Criteria section to Good First Issue template for better contributor guidance (#997)
1820

1921
### Changed
22+
2023
- Allow `PublicKey` for `TokenUpdateKeys` in `TokenUpdateTransaction`, enabling non-custodial workflows where operators can build transactions using only public keys (#934).
2124
- Bump protobuf toml to protobuf==6.33.2
2225

2326
### Fixed
27+
2428
- Fixed inactivity bot workflow not checking out repository before running (#964)
2529
- Fixed the topic_message_query integarion test
2630
- good first issue template yaml rendering

0 commit comments

Comments
 (0)