Skip to content

Commit 167ad42

Browse files
committed
test(integration): align secrets name casing and ResultInfo field
1 parent affa3ae commit 167ad42

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

tests/integration/test_query_async_polling.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,9 @@ def test_query_async_polling(
8181
assert result.row_count == 1
8282
assert result.rows == [[1]]
8383

84+
# ResultInfo (list_results) exposes the id as `id`, not `result_id` —
85+
# only GetResultResponse uses `result_id`.
8486
results_listing = results_api.list_results(limit=50)
85-
assert any(r.result_id == run.result_id for r in results_listing.results), (
87+
assert any(r.id == run.result_id for r in results_listing.results), (
8688
f"result {run.result_id} not surfaced by list_results"
8789
)

tests/integration/test_secrets_crud.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,9 @@
1818
from hotdata.models.update_secret_request import UpdateSecretRequest
1919

2020

21-
def _name_for(scenario_name: str) -> str:
22-
# Secret names are uppercase + underscores by convention.
23-
return scenario_name.replace("-", "_").upper()
24-
25-
2621
def test_secrets_crud(secrets_api: SecretsApi, sdkci_name) -> None:
27-
secret_name = _name_for(sdkci_name("secrets-crud"))
22+
# Server normalizes secret names — pass through whatever sdkci_name returns.
23+
secret_name = sdkci_name("secrets-crud").replace("-", "_")
2824
initial_value = "INITIAL_PLAINTEXT_VALUE_DO_NOT_LEAK"
2925
updated_value = "UPDATED_PLAINTEXT_VALUE_DO_NOT_LEAK"
3026
created = False

0 commit comments

Comments
 (0)