Skip to content

Conversation

@jwatson-gcu
Copy link

This PR proposes two things:

  1. Adding a service.ServiceOption to provide a tls.Config to NewNimbleGroupService() which is in turn used by resty.Client

    The current behavior hard codes the tls connection to skip certificate verification, which is something that is not allowed in our security environment.

	restyClient.SetTLSClientConfig(&tls.Config{
		InsecureSkipVerify: true,
	})
  1. When using a Tenant User, certificates are fully validated.

Signed-off-by: Joseph Watson jwatson@genisyscu.org

connection

Signed-off-by: Joseph Watson <jwatson@genisyscu.org>
@jwatson-gcu
Copy link
Author

Example usage:

	nimbleClient, err := service.NewNimbleGroupService(
		service.WithHost(config.Host),
		service.WithUser(config.User),
		service.WithPassword(config.Password),
		service.WithTLSConfig(tlsConfig),
	)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant