Wrap update_profile_params serialization failures

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/session.py

@@ -276,11 +276,23 @@ async def update_profile_params(
                 "update_profile_params() requires either UpdateSessionProfileParams or a boolean persist_changes."
             )
 
+        try:
+            serialized_params = params_obj.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize update_profile_params payload",
+                original_error=exc,
+            ) from exc
+        if type(serialized_params) is not dict:
+            raise HyperbrowserError("Failed to serialize update_profile_params payload")
+
         response = await self._client.transport.put(
             self._client._build_url(f"/session/{id}/update"),
             data={
                 "type": "profile",
-                "params": params_obj.model_dump(exclude_none=True, by_alias=True),
+                "params": serialized_params,
             },
         )
         return parse_session_response_model(

hyperbrowser/client/managers/sync_manager/session.py

@@ -268,11 +268,23 @@ def update_profile_params(
                 "update_profile_params() requires either UpdateSessionProfileParams or a boolean persist_changes."
             )
 
+        try:
+            serialized_params = params_obj.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize update_profile_params payload",
+                original_error=exc,
+            ) from exc
+        if type(serialized_params) is not dict:
+            raise HyperbrowserError("Failed to serialize update_profile_params payload")
+
         response = self._client.transport.put(
             self._client._build_url(f"/session/{id}/update"),
             data={
                 "type": "profile",
-                "params": params_obj.model_dump(exclude_none=True, by_alias=True),
+                "params": serialized_params,
             },
         )
         return parse_session_response_model(

tests/test_session_update_profile_params.py

@@ -105,6 +105,52 @@ class _Params(UpdateSessionProfileParams):
         manager.update_profile_params("session-1", _Params(persist_changes=True))
 
 
+def test_sync_update_profile_params_wraps_serialization_errors(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    manager = SyncSessionManager(_SyncClient())
+    params = UpdateSessionProfileParams(persist_changes=True)
+
+    def _raise_model_dump_error(*args, **kwargs):
+        _ = args
+        _ = kwargs
+        raise RuntimeError("broken model_dump")
+
+    monkeypatch.setattr(
+        UpdateSessionProfileParams, "model_dump", _raise_model_dump_error
+    )
+
+    with pytest.raises(
+        HyperbrowserError, match="Failed to serialize update_profile_params payload"
+    ) as exc_info:
+        manager.update_profile_params("session-1", params)
+
+    assert isinstance(exc_info.value.original_error, RuntimeError)
+
+
+def test_sync_update_profile_params_preserves_hyperbrowser_serialization_errors(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    manager = SyncSessionManager(_SyncClient())
+    params = UpdateSessionProfileParams(persist_changes=True)
+
+    def _raise_model_dump_error(*args, **kwargs):
+        _ = args
+        _ = kwargs
+        raise HyperbrowserError("custom model_dump failure")
+
+    monkeypatch.setattr(
+        UpdateSessionProfileParams, "model_dump", _raise_model_dump_error
+    )
+
+    with pytest.raises(
+        HyperbrowserError, match="custom model_dump failure"
+    ) as exc_info:
+        manager.update_profile_params("session-1", params)
+
+    assert exc_info.value.original_error is None
+
+
 def test_async_update_profile_params_bool_warns_and_serializes():
     AsyncSessionManager._has_warned_update_profile_params_boolean_deprecated = False
     client = _AsyncClient()
@@ -164,6 +210,56 @@ async def run() -> None:
     asyncio.run(run())
 
 
+def test_async_update_profile_params_wraps_serialization_errors(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    manager = AsyncSessionManager(_AsyncClient())
+    params = UpdateSessionProfileParams(persist_changes=True)
+
+    def _raise_model_dump_error(*args, **kwargs):
+        _ = args
+        _ = kwargs
+        raise RuntimeError("broken model_dump")
+
+    monkeypatch.setattr(
+        UpdateSessionProfileParams, "model_dump", _raise_model_dump_error
+    )
+
+    async def run() -> None:
+        with pytest.raises(
+            HyperbrowserError, match="Failed to serialize update_profile_params payload"
+        ) as exc_info:
+            await manager.update_profile_params("session-1", params)
+        assert isinstance(exc_info.value.original_error, RuntimeError)
+
+    asyncio.run(run())
+
+
+def test_async_update_profile_params_preserves_hyperbrowser_serialization_errors(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    manager = AsyncSessionManager(_AsyncClient())
+    params = UpdateSessionProfileParams(persist_changes=True)
+
+    def _raise_model_dump_error(*args, **kwargs):
+        _ = args
+        _ = kwargs
+        raise HyperbrowserError("custom model_dump failure")
+
+    monkeypatch.setattr(
+        UpdateSessionProfileParams, "model_dump", _raise_model_dump_error
+    )
+
+    async def run() -> None:
+        with pytest.raises(
+            HyperbrowserError, match="custom model_dump failure"
+        ) as exc_info:
+            await manager.update_profile_params("session-1", params)
+        assert exc_info.value.original_error is None
+
+    asyncio.run(run())
+
+
 def test_sync_update_profile_params_requires_argument_or_keyword():
     manager = SyncSessionManager(_SyncClient())