Validate transport api_key type and emptiness

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/async_transport.py

@@ -13,8 +13,13 @@ class AsyncTransport(AsyncTransportStrategy):
     """Asynchronous transport implementation using httpx"""
 
     def __init__(self, api_key: str, headers: Optional[Mapping[str, str]] = None):
+        if not isinstance(api_key, str):
+            raise HyperbrowserError("api_key must be a string")
+        normalized_api_key = api_key.strip()
+        if not normalized_api_key:
+            raise HyperbrowserError("api_key must not be empty")
         merged_headers = {
-            "x-api-key": api_key,
+            "x-api-key": normalized_api_key,
             "User-Agent": f"hyperbrowser-python-sdk/{__version__}",
         }
         normalized_headers = normalize_headers(

hyperbrowser/transport/sync.py

@@ -13,8 +13,13 @@ class SyncTransport(SyncTransportStrategy):
     """Synchronous transport implementation using httpx"""
 
     def __init__(self, api_key: str, headers: Optional[Mapping[str, str]] = None):
+        if not isinstance(api_key, str):
+            raise HyperbrowserError("api_key must be a string")
+        normalized_api_key = api_key.strip()
+        if not normalized_api_key:
+            raise HyperbrowserError("api_key must not be empty")
         merged_headers = {
-            "x-api-key": api_key,
+            "x-api-key": normalized_api_key,
             "User-Agent": f"hyperbrowser-python-sdk/{__version__}",
         }
         normalized_headers = normalize_headers(

tests/test_custom_headers.py

@@ -28,6 +28,13 @@ def test_sync_transport_rejects_non_string_header_pairs():
         SyncTransport(api_key="test-key", headers={"X-Correlation-Id": 123})  # type: ignore[dict-item]
 
 
+def test_sync_transport_rejects_invalid_api_key_values():
+    with pytest.raises(HyperbrowserError, match="api_key must be a string"):
+        SyncTransport(api_key=None)  # type: ignore[arg-type]
+    with pytest.raises(HyperbrowserError, match="api_key must not be empty"):
+        SyncTransport(api_key="   ")
+
+
 def test_sync_transport_rejects_empty_header_name():
     with pytest.raises(HyperbrowserError, match="header names must not be empty"):
         SyncTransport(api_key="test-key", headers={"   ": "value"})
@@ -61,6 +68,13 @@ def test_async_transport_rejects_non_string_header_pairs():
         AsyncTransport(api_key="test-key", headers={"X-Correlation-Id": 123})  # type: ignore[dict-item]
 
 
+def test_async_transport_rejects_invalid_api_key_values():
+    with pytest.raises(HyperbrowserError, match="api_key must be a string"):
+        AsyncTransport(api_key=None)  # type: ignore[arg-type]
+    with pytest.raises(HyperbrowserError, match="api_key must not be empty"):
+        AsyncTransport(api_key="   ")
+
+
 def test_async_transport_rejects_empty_header_name():
     with pytest.raises(HyperbrowserError, match="header names must not be empty"):
         AsyncTransport(api_key="test-key", headers={"   ": "value"})