Skip to content

Commit 13a0eff

Browse files
Deduplicate transport request-error message formatting in response handler
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent 3eb29a6 commit 13a0eff

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

hyperbrowser/transport/async_transport.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from .base import APIResponse, AsyncTransportStrategy
99
from .error_utils import (
1010
extract_error_message,
11-
extract_request_error_context,
1211
format_generic_request_failure_message,
1312
format_request_failure_message,
1413
)
@@ -75,9 +74,13 @@ async def _handle_response(self, response: httpx.Response) -> APIResponse:
7574
original_error=e,
7675
)
7776
except httpx.RequestError as e:
78-
request_method, request_url = extract_request_error_context(e)
7977
raise HyperbrowserError(
80-
f"Request {request_method} {request_url} failed", original_error=e
78+
format_request_failure_message(
79+
e,
80+
fallback_method="UNKNOWN",
81+
fallback_url="unknown URL",
82+
),
83+
original_error=e,
8184
)
8285

8386
async def post(

hyperbrowser/transport/sync.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from .base import APIResponse, SyncTransportStrategy
99
from .error_utils import (
1010
extract_error_message,
11-
extract_request_error_context,
1211
format_generic_request_failure_message,
1312
format_request_failure_message,
1413
)
@@ -63,9 +62,13 @@ def _handle_response(self, response: httpx.Response) -> APIResponse:
6362
original_error=e,
6463
)
6564
except httpx.RequestError as e:
66-
request_method, request_url = extract_request_error_context(e)
6765
raise HyperbrowserError(
68-
f"Request {request_method} {request_url} failed", original_error=e
66+
format_request_failure_message(
67+
e,
68+
fallback_method="UNKNOWN",
69+
fallback_url="unknown URL",
70+
),
71+
original_error=e,
6972
)
7073

7174
def close(self) -> None:

0 commit comments

Comments
 (0)