Skip to content

Commit 2021169

Browse files
Add file-path display helper architecture guard
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent c03459f commit 2021169

File tree

3 files changed

+20
-0
lines changed

3 files changed

+20
-0
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ This runs lint, format checks, compile checks, tests, and package build.
133133
- `tests/test_extension_request_internal_reuse.py` (extension request-helper internal reuse of shared model request helpers),
134134
- `tests/test_extension_route_constants_usage.py` (extension manager route-constant usage enforcement),
135135
- `tests/test_extract_payload_helper_usage.py` (extract start-payload helper usage enforcement),
136+
- `tests/test_file_path_display_helper_usage.py` (shared file-path display helper usage enforcement),
136137
- `tests/test_guardrail_ast_utils.py` (shared AST guard utility contract),
137138
- `tests/test_helper_transport_usage_boundary.py` (manager-helper transport usage boundary enforcement through shared model request helpers),
138139
- `tests/test_job_fetch_helper_boundary.py` (centralization boundary enforcement for retry/paginated-fetch helper primitives),

tests/test_architecture_marker_usage.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
"tests/test_model_request_wrapper_internal_reuse.py",
5151
"tests/test_tool_mapping_reader_usage.py",
5252
"tests/test_display_helper_usage.py",
53+
"tests/test_file_path_display_helper_usage.py",
5354
"tests/test_binary_file_open_helper_usage.py",
5455
"tests/test_browser_use_payload_helper_usage.py",
5556
"tests/test_ci_workflow_quality_gates.py",
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
from pathlib import Path
2+
3+
import pytest
4+
5+
pytestmark = pytest.mark.architecture
6+
7+
8+
FILE_PATH_DISPLAY_MODULES = (
9+
"hyperbrowser/client/managers/extension_create_utils.py",
10+
"hyperbrowser/client/managers/session_upload_utils.py",
11+
)
12+
13+
14+
def test_file_path_error_messages_use_shared_display_helper():
15+
for module_path in FILE_PATH_DISPLAY_MODULES:
16+
module_text = Path(module_path).read_text(encoding="utf-8")
17+
assert "format_file_path_for_error(" in module_text
18+
assert "ord(character) < 32" not in module_text

0 commit comments

Comments
 (0)