Centralize team manager request and metadata handling

cursoragent · shrisukhani · cursoragent · commit 26b12afb2a03 · 2026-02-14T15:01:37.000Z
Co-authored-by: Shri Sukhani &lt;shrisukhani@users.noreply.github.com&gt;
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -139,6 +139,9 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_start_and_wait_default_constants_usage.py` (shared start-and-wait default-constant usage enforcement),
   - `tests/test_start_job_context_helper_usage.py` (shared started-job context helper usage enforcement),
   - `tests/test_started_job_helper_boundary.py` (centralization boundary enforcement for started-job helper primitives),
+  - `tests/test_team_operation_metadata_usage.py` (team manager operation-metadata usage enforcement),
+  - `tests/test_team_request_helper_usage.py` (team manager request-helper usage enforcement),
+  - `tests/test_team_route_constants_usage.py` (team manager route-constant usage enforcement),
   - `tests/test_tool_mapping_reader_usage.py` (tools mapping-helper usage),
   - `tests/test_type_utils_usage.py` (type `__mro__` boundary centralization in `hyperbrowser/type_utils.py`),
   - `tests/test_web_operation_metadata_usage.py` (web manager operation-metadata usage enforcement),
diff --git a/hyperbrowser/client/managers/async_manager/team.py b/hyperbrowser/client/managers/async_manager/team.py
@@ -1,17 +1,20 @@
 from hyperbrowser.models import TeamCreditInfo
-from ..response_utils import parse_response_model
+from ..team_operation_metadata import TEAM_OPERATION_METADATA
+from ..team_request_utils import get_team_resource_async
+from ..team_route_constants import TEAM_CREDIT_INFO_ROUTE_PATH
 
 
 class TeamManager:
+    _OPERATION_METADATA = TEAM_OPERATION_METADATA
+    _CREDIT_INFO_ROUTE_PATH = TEAM_CREDIT_INFO_ROUTE_PATH
+
     def __init__(self, client):
         self._client = client
 
     async def get_credit_info(self) -> TeamCreditInfo:
-        response = await self._client.transport.get(
-            self._client._build_url("/team/credit-info")
-        )
-        return parse_response_model(
-            response.data,
+        return await get_team_resource_async(
+            client=self._client,
+            route_path=self._CREDIT_INFO_ROUTE_PATH,
             model=TeamCreditInfo,
-            operation_name="team credit info",
+            operation_name=self._OPERATION_METADATA.get_credit_info_operation_name,
         )
diff --git a/hyperbrowser/client/managers/sync_manager/team.py b/hyperbrowser/client/managers/sync_manager/team.py
@@ -1,17 +1,20 @@
 from hyperbrowser.models import TeamCreditInfo
-from ..response_utils import parse_response_model
+from ..team_operation_metadata import TEAM_OPERATION_METADATA
+from ..team_request_utils import get_team_resource
+from ..team_route_constants import TEAM_CREDIT_INFO_ROUTE_PATH
 
 
 class TeamManager:
+    _OPERATION_METADATA = TEAM_OPERATION_METADATA
+    _CREDIT_INFO_ROUTE_PATH = TEAM_CREDIT_INFO_ROUTE_PATH
+
     def __init__(self, client):
         self._client = client
 
     def get_credit_info(self) -> TeamCreditInfo:
-        response = self._client.transport.get(
-            self._client._build_url("/team/credit-info")
-        )
-        return parse_response_model(
-            response.data,
+        return get_team_resource(
+            client=self._client,
+            route_path=self._CREDIT_INFO_ROUTE_PATH,
             model=TeamCreditInfo,
-            operation_name="team credit info",
+            operation_name=self._OPERATION_METADATA.get_credit_info_operation_name,
         )
diff --git a/hyperbrowser/client/managers/team_operation_metadata.py b/hyperbrowser/client/managers/team_operation_metadata.py
@@ -0,0 +1,11 @@
+from dataclasses import dataclass
+
+
+@dataclass(frozen=True)
+class TeamOperationMetadata:
+    get_credit_info_operation_name: str
+
+
+TEAM_OPERATION_METADATA = TeamOperationMetadata(
+    get_credit_info_operation_name="team credit info",
+)
diff --git a/hyperbrowser/client/managers/team_request_utils.py b/hyperbrowser/client/managers/team_request_utils.py
@@ -0,0 +1,39 @@
+from typing import Any, Type, TypeVar
+
+from .response_utils import parse_response_model
+
+T = TypeVar("T")
+
+
+def get_team_resource(
+    *,
+    client: Any,
+    route_path: str,
+    model: Type[T],
+    operation_name: str,
+) -> T:
+    response = client.transport.get(
+        client._build_url(route_path),
+    )
+    return parse_response_model(
+        response.data,
+        model=model,
+        operation_name=operation_name,
+    )
+
+
+async def get_team_resource_async(
+    *,
+    client: Any,
+    route_path: str,
+    model: Type[T],
+    operation_name: str,
+) -> T:
+    response = await client.transport.get(
+        client._build_url(route_path),
+    )
+    return parse_response_model(
+        response.data,
+        model=model,
+        operation_name=operation_name,
+    )
diff --git a/hyperbrowser/client/managers/team_route_constants.py b/hyperbrowser/client/managers/team_route_constants.py
@@ -0,0 +1 @@
+TEAM_CREDIT_INFO_ROUTE_PATH = "/team/credit-info"
diff --git a/tests/test_architecture_marker_usage.py b/tests/test_architecture_marker_usage.py
@@ -71,6 +71,9 @@
     "tests/test_start_and_wait_default_constants_usage.py",
     "tests/test_start_job_context_helper_usage.py",
     "tests/test_started_job_helper_boundary.py",
+    "tests/test_team_operation_metadata_usage.py",
+    "tests/test_team_request_helper_usage.py",
+    "tests/test_team_route_constants_usage.py",
     "tests/test_web_operation_metadata_usage.py",
     "tests/test_web_pagination_internal_reuse.py",
     "tests/test_web_payload_helper_usage.py",
diff --git a/tests/test_core_type_helper_usage.py b/tests/test_core_type_helper_usage.py
@@ -55,6 +55,9 @@
     "hyperbrowser/client/managers/session_operation_metadata.py",
     "hyperbrowser/client/managers/session_route_constants.py",
     "hyperbrowser/client/managers/session_upload_utils.py",
+    "hyperbrowser/client/managers/team_operation_metadata.py",
+    "hyperbrowser/client/managers/team_request_utils.py",
+    "hyperbrowser/client/managers/team_route_constants.py",
     "hyperbrowser/client/managers/session_profile_update_utils.py",
     "hyperbrowser/client/managers/web_operation_metadata.py",
     "hyperbrowser/client/managers/web_request_utils.py",
diff --git a/tests/test_team_operation_metadata.py b/tests/test_team_operation_metadata.py
@@ -0,0 +1,7 @@
+from hyperbrowser.client.managers.team_operation_metadata import (
+    TEAM_OPERATION_METADATA,
+)
+
+
+def test_team_operation_metadata_values():
+    assert TEAM_OPERATION_METADATA.get_credit_info_operation_name == "team credit info"
diff --git a/tests/test_team_operation_metadata_usage.py b/tests/test_team_operation_metadata_usage.py
@@ -0,0 +1,20 @@
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.architecture
+
+
+MODULES = (
+    "hyperbrowser/client/managers/sync_manager/team.py",
+    "hyperbrowser/client/managers/async_manager/team.py",
+)
+
+
+def test_team_managers_use_shared_operation_metadata():
+    for module_path in MODULES:
+        module_text = Path(module_path).read_text(encoding="utf-8")
+        assert "team_operation_metadata import" in module_text
+        assert "_OPERATION_METADATA = " in module_text
+        assert "operation_name=self._OPERATION_METADATA." in module_text
+        assert 'operation_name="' not in module_text
diff --git a/tests/test_team_request_helper_usage.py b/tests/test_team_request_helper_usage.py
@@ -0,0 +1,23 @@
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.architecture
+
+
+def test_sync_team_manager_uses_shared_request_helper():
+    module_text = Path("hyperbrowser/client/managers/sync_manager/team.py").read_text(
+        encoding="utf-8"
+    )
+    assert "get_team_resource(" in module_text
+    assert "_client.transport.get(" not in module_text
+    assert "parse_response_model(" not in module_text
+
+
+def test_async_team_manager_uses_shared_request_helper():
+    module_text = Path("hyperbrowser/client/managers/async_manager/team.py").read_text(
+        encoding="utf-8"
+    )
+    assert "get_team_resource_async(" in module_text
+    assert "_client.transport.get(" not in module_text
+    assert "parse_response_model(" not in module_text
diff --git a/tests/test_team_request_utils.py b/tests/test_team_request_utils.py
@@ -0,0 +1,82 @@
+import asyncio
+from types import SimpleNamespace
+
+import hyperbrowser.client.managers.team_request_utils as team_request_utils
+
+
+def test_get_team_resource_uses_route_and_parses_response():
+    captured = {}
+
+    class _SyncTransport:
+        def get(self, url):
+            captured["url"] = url
+            return SimpleNamespace(data={"remainingCredits": 42})
+
+    class _Client:
+        transport = _SyncTransport()
+
+        @staticmethod
+        def _build_url(path: str) -> str:
+            return f"https://api.example.test{path}"
+
+    def _fake_parse_response_model(data, **kwargs):
+        captured["parse_data"] = data
+        captured["parse_kwargs"] = kwargs
+        return {"parsed": True}
+
+    original_parse = team_request_utils.parse_response_model
+    team_request_utils.parse_response_model = _fake_parse_response_model
+    try:
+        result = team_request_utils.get_team_resource(
+            client=_Client(),
+            route_path="/team/credit-info",
+            model=object,
+            operation_name="team credit info",
+        )
+    finally:
+        team_request_utils.parse_response_model = original_parse
+
+    assert result == {"parsed": True}
+    assert captured["url"] == "https://api.example.test/team/credit-info"
+    assert captured["parse_data"] == {"remainingCredits": 42}
+    assert captured["parse_kwargs"]["operation_name"] == "team credit info"
+
+
+def test_get_team_resource_async_uses_route_and_parses_response():
+    captured = {}
+
+    class _AsyncTransport:
+        async def get(self, url):
+            captured["url"] = url
+            return SimpleNamespace(data={"remainingCredits": 42})
+
+    class _Client:
+        transport = _AsyncTransport()
+
+        @staticmethod
+        def _build_url(path: str) -> str:
+            return f"https://api.example.test{path}"
+
+    def _fake_parse_response_model(data, **kwargs):
+        captured["parse_data"] = data
+        captured["parse_kwargs"] = kwargs
+        return {"parsed": True}
+
+    original_parse = team_request_utils.parse_response_model
+    team_request_utils.parse_response_model = _fake_parse_response_model
+    try:
+        result = asyncio.run(
+            team_request_utils.get_team_resource_async(
+                client=_Client(),
+                route_path="/team/credit-info",
+                model=object,
+                operation_name="team credit info",
+            )
+        )
+    finally:
+        team_request_utils.parse_response_model = original_parse
+
+    assert result == {"parsed": True}
+    assert captured["url"] == "https://api.example.test/team/credit-info"
+    assert captured["parse_data"] == {"remainingCredits": 42}
+    assert captured["parse_kwargs"]["operation_name"] == "team credit info"
diff --git a/tests/test_team_route_constants.py b/tests/test_team_route_constants.py
@@ -0,0 +1,7 @@
+from hyperbrowser.client.managers.team_route_constants import (
+    TEAM_CREDIT_INFO_ROUTE_PATH,
+)
+
+
+def test_team_route_constants_match_expected_api_paths():
+    assert TEAM_CREDIT_INFO_ROUTE_PATH == "/team/credit-info"
diff --git a/tests/test_team_route_constants_usage.py b/tests/test_team_route_constants_usage.py
@@ -0,0 +1,19 @@
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.architecture
+
+
+MODULES = (
+    "hyperbrowser/client/managers/sync_manager/team.py",
+    "hyperbrowser/client/managers/async_manager/team.py",
+)
+
+
+def test_team_managers_use_shared_route_constants():
+    for module_path in MODULES:
+        module_text = Path(module_path).read_text(encoding="utf-8")
+        assert "team_route_constants import" in module_text
+        assert "_CREDIT_INFO_ROUTE_PATH = " in module_text
+        assert '"/team/credit-info"' not in module_text

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+TEAM_CREDIT_INFO_ROUTE_PATH = "/team/credit-info"`