Improve session recording value-read diagnostics

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/session_utils.py

@@ -6,6 +6,23 @@
 from .response_utils import parse_response_model
 
 T = TypeVar("T")
+_MAX_KEY_DISPLAY_LENGTH = 120
+_TRUNCATED_KEY_DISPLAY_SUFFIX = "... (truncated)"
+
+
+def _format_recording_key_display(key: str) -> str:
+    normalized_key = "".join(
+        "?" if ord(character) < 32 or ord(character) == 127 else character
+        for character in key
+    ).strip()
+    if not normalized_key:
+        return "<blank key>"
+    if len(normalized_key) <= _MAX_KEY_DISPLAY_LENGTH:
+        return normalized_key
+    available_length = _MAX_KEY_DISPLAY_LENGTH - len(_TRUNCATED_KEY_DISPLAY_SUFFIX)
+    if available_length <= 0:
+        return _TRUNCATED_KEY_DISPLAY_SUFFIX
+    return f"{normalized_key[:available_length]}{_TRUNCATED_KEY_DISPLAY_SUFFIX}"
 
 
 def parse_session_response_model(
@@ -45,20 +62,33 @@ def parse_session_recordings_response_data(
                 f"{index} but got {type(recording).__name__}"
             )
         try:
-            recording_payload = dict(recording)
+            recording_keys = list(recording.keys())
         except HyperbrowserError:
             raise
         except Exception as exc:
             raise HyperbrowserError(
                 f"Failed to read session recording object at index {index}",
                 original_error=exc,
             ) from exc
-        for key in recording_payload.keys():
+        for key in recording_keys:
             if isinstance(key, str):
                 continue
             raise HyperbrowserError(
                 f"Expected session recording object keys to be strings at index {index}"
             )
+        recording_payload: dict[str, object] = {}
+        for key in recording_keys:
+            try:
+                recording_payload[key] = recording[key]
+            except HyperbrowserError:
+                raise
+            except Exception as exc:
+                key_display = _format_recording_key_display(key)
+                raise HyperbrowserError(
+                    "Failed to read session recording object value for key "
+                    f"'{key_display}' at index {index}",
+                    original_error=exc,
+                ) from exc
         try:
             parsed_recordings.append(SessionRecording(**recording_payload))
         except HyperbrowserError:

tests/test_session_recording_utils.py

@@ -237,6 +237,71 @@ def test_parse_session_recordings_response_data_rejects_non_string_recording_key
         )
 
 
+def test_parse_session_recordings_response_data_wraps_recording_value_read_failures():
+    class _BrokenValueLookupMapping(Mapping[str, object]):
+        def __iter__(self) -> Iterator[str]:
+            yield "type"
+
+        def __len__(self) -> int:
+            return 1
+
+        def __getitem__(self, key: str) -> object:
+            _ = key
+            raise RuntimeError("cannot read recording value")
+
+    with pytest.raises(
+        HyperbrowserError,
+        match="Failed to read session recording object value for key 'type' at index 0",
+    ) as exc_info:
+        parse_session_recordings_response_data([_BrokenValueLookupMapping()])
+
+    assert exc_info.value.original_error is not None
+
+
+def test_parse_session_recordings_response_data_sanitizes_recording_value_keys():
+    class _BrokenValueLookupMapping(Mapping[str, object]):
+        def __iter__(self) -> Iterator[str]:
+            yield "bad\tkey"
+
+        def __len__(self) -> int:
+            return 1
+
+        def __getitem__(self, key: str) -> object:
+            _ = key
+            raise RuntimeError("cannot read recording value")
+
+    with pytest.raises(
+        HyperbrowserError,
+        match=(
+            "Failed to read session recording object value "
+            "for key 'bad\\?key' at index 0"
+        ),
+    ) as exc_info:
+        parse_session_recordings_response_data([_BrokenValueLookupMapping()])
+
+    assert exc_info.value.original_error is not None
+
+
+def test_parse_session_recordings_response_data_preserves_hyperbrowser_value_read_errors():
+    class _BrokenValueLookupMapping(Mapping[str, object]):
+        def __iter__(self) -> Iterator[str]:
+            yield "type"
+
+        def __len__(self) -> int:
+            return 1
+
+        def __getitem__(self, key: str) -> object:
+            _ = key
+            raise HyperbrowserError("custom recording value read failure")
+
+    with pytest.raises(
+        HyperbrowserError, match="custom recording value read failure"
+    ) as exc_info:
+        parse_session_recordings_response_data([_BrokenValueLookupMapping()])
+
+    assert exc_info.value.original_error is None
+
+
 def test_parse_session_recordings_response_data_wraps_unreadable_list_iteration():
     class _BrokenRecordingList(list):
         def __iter__(self):