Wrap invalid PathLike state in session upload managers

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/session.py

@@ -151,7 +151,15 @@ async def upload_file(
         self, id: str, file_input: Union[str, PathLike[str], IO]
     ) -> UploadFileResponse:
         if isinstance(file_input, (str, PathLike)):
-            raw_file_path = os.fspath(file_input)
+            try:
+                raw_file_path = os.fspath(file_input)
+            except HyperbrowserError:
+                raise
+            except Exception as exc:
+                raise HyperbrowserError(
+                    "file_input path is invalid",
+                    original_error=exc,
+                ) from exc
             file_path = ensure_existing_file_path(
                 raw_file_path,
                 missing_file_message=f"Upload file not found at path: {raw_file_path}",

hyperbrowser/client/managers/sync_manager/session.py

@@ -143,7 +143,15 @@ def upload_file(
         self, id: str, file_input: Union[str, PathLike[str], IO]
     ) -> UploadFileResponse:
         if isinstance(file_input, (str, PathLike)):
-            raw_file_path = os.fspath(file_input)
+            try:
+                raw_file_path = os.fspath(file_input)
+            except HyperbrowserError:
+                raise
+            except Exception as exc:
+                raise HyperbrowserError(
+                    "file_input path is invalid",
+                    original_error=exc,
+                ) from exc
             file_path = ensure_existing_file_path(
                 raw_file_path,
                 missing_file_message=f"Upload file not found at path: {raw_file_path}",

tests/test_session_upload_file.py

@@ -1,5 +1,6 @@
 import asyncio
 import io
+from os import PathLike
 from pathlib import Path
 import pytest
 
@@ -140,6 +141,38 @@ async def run():
     asyncio.run(run())
 
 
+def test_sync_session_upload_file_wraps_invalid_pathlike_state_errors():
+    manager = SyncSessionManager(_FakeClient(_SyncTransport()))
+
+    class _BrokenPathLike(PathLike[str]):
+        def __fspath__(self) -> str:
+            raise RuntimeError("broken fspath")
+
+    with pytest.raises(
+        HyperbrowserError, match="file_input path is invalid"
+    ) as exc_info:
+        manager.upload_file("session_123", _BrokenPathLike())
+
+    assert isinstance(exc_info.value.original_error, RuntimeError)
+
+
+def test_async_session_upload_file_wraps_invalid_pathlike_state_errors():
+    manager = AsyncSessionManager(_FakeClient(_AsyncTransport()))
+
+    class _BrokenPathLike(PathLike[str]):
+        def __fspath__(self) -> str:
+            raise RuntimeError("broken fspath")
+
+    async def run():
+        with pytest.raises(
+            HyperbrowserError, match="file_input path is invalid"
+        ) as exc_info:
+            await manager.upload_file("session_123", _BrokenPathLike())
+        assert isinstance(exc_info.value.original_error, RuntimeError)
+
+    asyncio.run(run())
+
+
 def test_sync_session_upload_file_rejects_non_callable_read_attribute():
     manager = SyncSessionManager(_FakeClient(_SyncTransport()))
     fake_file = type("FakeFile", (), {"read": "not-callable"})()