Handle overflowing Real timing values gracefully

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -16,7 +16,11 @@
 def _validate_non_negative_real(value: float, *, field_name: str) -> None:
     if isinstance(value, bool) or not isinstance(value, Real):
         raise HyperbrowserError(f"{field_name} must be a number")
-    if not math.isfinite(float(value)):
+    try:
+        is_finite = math.isfinite(value)
+    except (TypeError, ValueError, OverflowError):
+        is_finite = False
+    if not is_finite:
         raise HyperbrowserError(f"{field_name} must be finite")
     if value < 0:
         raise HyperbrowserError(f"{field_name} must be non-negative")

hyperbrowser/client/timeout_utils.py

@@ -10,7 +10,11 @@ def validate_timeout_seconds(timeout: Optional[float]) -> None:
         return
     if isinstance(timeout, bool) or not isinstance(timeout, Real):
         raise HyperbrowserError("timeout must be a number")
-    if not math.isfinite(float(timeout)):
+    try:
+        is_finite = math.isfinite(timeout)
+    except (TypeError, ValueError, OverflowError):
+        is_finite = False
+    if not is_finite:
         raise HyperbrowserError("timeout must be finite")
     if timeout < 0:
         raise HyperbrowserError("timeout must be non-negative")

tests/test_client_timeout.py

@@ -1,5 +1,6 @@
 import asyncio
 import math
+from fractions import Fraction
 
 import pytest
 
@@ -60,3 +61,13 @@ def test_sync_client_rejects_non_finite_timeout(invalid_timeout: float):
 def test_async_client_rejects_non_finite_timeout(invalid_timeout: float):
     with pytest.raises(HyperbrowserError, match="timeout must be finite"):
         AsyncHyperbrowser(api_key="test-key", timeout=invalid_timeout)
+
+
+def test_sync_client_rejects_overflowing_real_timeout():
+    with pytest.raises(HyperbrowserError, match="timeout must be finite"):
+        Hyperbrowser(api_key="test-key", timeout=Fraction(10**1000, 1))
+
+
+def test_async_client_rejects_overflowing_real_timeout():
+    with pytest.raises(HyperbrowserError, match="timeout must be finite"):
+        AsyncHyperbrowser(api_key="test-key", timeout=Fraction(10**1000, 1))

tests/test_polling.py

@@ -1,5 +1,6 @@
 import asyncio
 import math
+from fractions import Fraction
 
 import pytest
 
@@ -785,6 +786,15 @@ def test_polling_helpers_validate_retry_and_interval_configuration():
             retry_delay_seconds=0.0,
         )
 
+    with pytest.raises(HyperbrowserError, match="poll_interval_seconds must be finite"):
+        poll_until_terminal_status(
+            operation_name="invalid-poll-interval-overflowing-real",
+            get_status=lambda: "completed",
+            is_terminal_status=lambda value: value == "completed",
+            poll_interval_seconds=Fraction(10**1000, 1),  # type: ignore[arg-type]
+            max_wait_seconds=1.0,
+        )
+
     async def validate_async_operation_name() -> None:
         with pytest.raises(HyperbrowserError, match="operation_name must not be empty"):
             await poll_until_terminal_status_async(