Share strict list normalization in manager parsing utilities

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/extension_utils.py

@@ -5,7 +5,7 @@
 from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models.extension import ExtensionResponse
 from hyperbrowser.type_utils import is_plain_string
-from .list_parsing_utils import parse_mapping_list_items
+from .list_parsing_utils import parse_mapping_list_items, read_plain_list_items
 
 _MAX_DISPLAYED_MISSING_KEYS = 20
 _MAX_DISPLAYED_MISSING_KEY_LENGTH = 120
@@ -84,20 +84,14 @@ def parse_extension_list_response_data(response_data: Any) -> List[ExtensionResp
             "Failed to read 'extensions' value from response",
             original_error=exc,
         ) from exc
-    if type(extensions_value) is not list:
-        raise HyperbrowserError(
+    extension_items = read_plain_list_items(
+        extensions_value,
+        expected_list_error=(
             "Expected list in 'extensions' key but got "
             f"{_get_type_name(extensions_value)}"
-        )
-    try:
-        extension_items = list(extensions_value)
-    except HyperbrowserError:
-        raise
-    except Exception as exc:
-        raise HyperbrowserError(
-            "Failed to iterate 'extensions' list from response",
-            original_error=exc,
-        ) from exc
+        ),
+        read_list_error="Failed to iterate 'extensions' list from response",
+    )
     return parse_mapping_list_items(
         extension_items,
         item_label="extension",

hyperbrowser/client/managers/list_parsing_utils.py

@@ -6,6 +6,22 @@
 T = TypeVar("T")
 
 
+def read_plain_list_items(
+    items_value: Any,
+    *,
+    expected_list_error: str,
+    read_list_error: str,
+) -> List[Any]:
+    if type(items_value) is not list:
+        raise HyperbrowserError(expected_list_error)
+    try:
+        return list(items_value)
+    except HyperbrowserError:
+        raise
+    except Exception as exc:
+        raise HyperbrowserError(read_list_error, original_error=exc) from exc
+
+
 def parse_mapping_list_items(
     items: List[Any],
     *,

hyperbrowser/client/managers/session_utils.py

@@ -1,9 +1,8 @@
 from typing import Any, List, Type, TypeVar
 
 from hyperbrowser.display_utils import format_string_key_for_error
-from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models.session import SessionRecording
-from .list_parsing_utils import parse_mapping_list_items
+from .list_parsing_utils import parse_mapping_list_items, read_plain_list_items
 from .response_utils import parse_response_model
 
 T = TypeVar("T")
@@ -30,19 +29,11 @@ def parse_session_response_model(
 def parse_session_recordings_response_data(
     response_data: Any,
 ) -> List[SessionRecording]:
-    if type(response_data) is not list:
-        raise HyperbrowserError(
-            "Expected session recording response to be a list of objects"
-        )
-    try:
-        recording_items = list(response_data)
-    except HyperbrowserError:
-        raise
-    except Exception as exc:
-        raise HyperbrowserError(
-            "Failed to iterate session recording response list",
-            original_error=exc,
-        ) from exc
+    recording_items = read_plain_list_items(
+        response_data,
+        expected_list_error="Expected session recording response to be a list of objects",
+        read_list_error="Failed to iterate session recording response list",
+    )
     return parse_mapping_list_items(
         recording_items,
         item_label="session recording",

tests/test_list_parsing_utils.py

@@ -3,7 +3,10 @@
 
 import pytest
 
-from hyperbrowser.client.managers.list_parsing_utils import parse_mapping_list_items
+from hyperbrowser.client.managers.list_parsing_utils import (
+    parse_mapping_list_items,
+    read_plain_list_items,
+)
 from hyperbrowser.exceptions import HyperbrowserError
 
 
@@ -141,3 +144,32 @@ def test_parse_mapping_list_items_wraps_parse_failures():
         )
 
     assert isinstance(exc_info.value.original_error, ZeroDivisionError)
+
+
+def test_read_plain_list_items_returns_list_values():
+    assert read_plain_list_items(
+        ["a", "b"],
+        expected_list_error="expected list",
+        read_list_error="failed list iteration",
+    ) == ["a", "b"]
+
+
+def test_read_plain_list_items_rejects_non_list_values():
+    with pytest.raises(HyperbrowserError, match="expected list"):
+        read_plain_list_items(
+            ("a", "b"),
+            expected_list_error="expected list",
+            read_list_error="failed list iteration",
+        )
+
+
+def test_read_plain_list_items_rejects_list_subclass_values():
+    class _ListSubclass(list):
+        pass
+
+    with pytest.raises(HyperbrowserError, match="expected list"):
+        read_plain_list_items(
+            _ListSubclass(["a"]),  # type: ignore[arg-type]
+            expected_list_error="expected list",
+            read_list_error="failed list iteration",
+        )