Reject integer subclasses in polling numeric validators

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -458,17 +458,15 @@ def _validate_retry_config(
     retry_delay_seconds: float,
     max_status_failures: Optional[int] = None,
 ) -> float:
-    if isinstance(max_attempts, bool) or not isinstance(max_attempts, int):
+    if type(max_attempts) is not int:
         raise HyperbrowserError("max_attempts must be an integer")
     if max_attempts < 1:
         raise HyperbrowserError("max_attempts must be at least 1")
     normalized_retry_delay_seconds = _normalize_non_negative_real(
         retry_delay_seconds, field_name="retry_delay_seconds"
     )
     if max_status_failures is not None:
-        if isinstance(max_status_failures, bool) or not isinstance(
-            max_status_failures, int
-        ):
+        if type(max_status_failures) is not int:
             raise HyperbrowserError("max_status_failures must be an integer")
         if max_status_failures < 1:
             raise HyperbrowserError("max_status_failures must be at least 1")
@@ -494,11 +492,11 @@ def _validate_page_batch_values(
     current_page_batch: int,
     total_page_batches: int,
 ) -> None:
-    if isinstance(current_page_batch, bool) or not isinstance(current_page_batch, int):
+    if type(current_page_batch) is not int:
         raise HyperbrowserPollingError(
             f"Invalid current page batch for {operation_name}: expected integer"
         )
-    if isinstance(total_page_batches, bool) or not isinstance(total_page_batches, int):
+    if type(total_page_batches) is not int:
         raise HyperbrowserPollingError(
             f"Invalid total page batches for {operation_name}: expected integer"
         )

tests/test_polling.py

@@ -68,8 +68,7 @@ def _raise_isfinite_error(value: float) -> bool:
     assert exc_info.value.original_error is not None
 
 
-def test_poll_until_terminal_status_wraps_unexpected_float_conversion_failures(
-):
+def test_poll_until_terminal_status_wraps_unexpected_float_conversion_failures():
     class _BrokenDecimal(Decimal):
         def __float__(self) -> float:
             raise RuntimeError("unexpected float conversion failure")
@@ -4080,6 +4079,30 @@ def test_collect_paginated_results_raises_on_invalid_page_batch_types():
         )
 
 
+def test_collect_paginated_results_raises_on_integer_subclass_page_batch_types():
+    class _IntSubclass(int):
+        pass
+
+    with pytest.raises(
+        HyperbrowserPollingError,
+        match="Invalid total page batches for sync paginated int-subclass types",
+    ):
+        collect_paginated_results(
+            operation_name="sync paginated int-subclass types",
+            get_next_page=lambda page: {
+                "current": 1,
+                "total": _IntSubclass(2),
+                "items": [],
+            },
+            get_current_page_batch=lambda response: response["current"],
+            get_total_page_batches=lambda response: response["total"],
+            on_page_success=lambda response: None,
+            max_wait_seconds=1.0,
+            max_attempts=2,
+            retry_delay_seconds=0.0001,
+        )
+
+
 def test_collect_paginated_results_raises_on_boolean_page_batch_values():
     with pytest.raises(
         HyperbrowserPollingError,
@@ -4179,6 +4202,32 @@ async def run() -> None:
     asyncio.run(run())
 
 
+def test_collect_paginated_results_async_raises_on_integer_subclass_page_batch_types():
+    class _IntSubclass(int):
+        pass
+
+    async def run() -> None:
+        with pytest.raises(
+            HyperbrowserPollingError,
+            match="Invalid current page batch for async paginated int-subclass types",
+        ):
+            await collect_paginated_results_async(
+                operation_name="async paginated int-subclass types",
+                get_next_page=lambda page: asyncio.sleep(
+                    0,
+                    result={"current": _IntSubclass(1), "total": 2, "items": []},
+                ),
+                get_current_page_batch=lambda response: response["current"],
+                get_total_page_batches=lambda response: response["total"],
+                on_page_success=lambda response: None,
+                max_wait_seconds=1.0,
+                max_attempts=2,
+                retry_delay_seconds=0.0001,
+            )
+
+    asyncio.run(run())
+
+
 def test_collect_paginated_results_async_raises_on_boolean_page_batch_values():
     async def run() -> None:
         with pytest.raises(
@@ -6686,6 +6735,9 @@ async def run() -> None:
 
 
 def test_polling_helpers_validate_retry_and_interval_configuration():
+    class _IntSubclass(int):
+        pass
+
     with pytest.raises(HyperbrowserError, match="max_attempts must be at least 1"):
         retry_operation(
             operation_name="invalid-retry",
@@ -6749,6 +6801,14 @@ def test_polling_helpers_validate_retry_and_interval_configuration():
             retry_delay_seconds=0,
         )
 
+    with pytest.raises(HyperbrowserError, match="max_attempts must be an integer"):
+        retry_operation(
+            operation_name="invalid-retry-int-subclass",
+            operation=lambda: "ok",
+            max_attempts=_IntSubclass(1),  # type: ignore[arg-type]
+            retry_delay_seconds=0,
+        )
+
     with pytest.raises(
         HyperbrowserError, match="retry_delay_seconds must be non-negative"
     ):
@@ -6783,6 +6843,18 @@ def test_polling_helpers_validate_retry_and_interval_configuration():
             max_status_failures=1.5,  # type: ignore[arg-type]
         )
 
+    with pytest.raises(
+        HyperbrowserError, match="max_status_failures must be an integer"
+    ):
+        poll_until_terminal_status(
+            operation_name="invalid-status-failures-int-subclass",
+            get_status=lambda: "completed",
+            is_terminal_status=lambda value: value == "completed",
+            poll_interval_seconds=0.1,
+            max_wait_seconds=1.0,
+            max_status_failures=_IntSubclass(1),  # type: ignore[arg-type]
+        )
+
     with pytest.raises(
         HyperbrowserError, match="poll_interval_seconds must be non-negative"
     ):