Add extension key-display import boundary guard

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -132,6 +132,7 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_extension_create_helper_usage.py` (extension create-input normalization helper usage enforcement),
   - `tests/test_extension_create_metadata_usage.py` (extension create-helper shared operation-metadata prefix usage enforcement),
   - `tests/test_extension_key_display_helper_usage.py` (extension missing-key display helper usage enforcement),
+  - `tests/test_extension_key_display_import_boundary.py` (extension key-display helper import boundary enforcement),
   - `tests/test_extension_operation_metadata_import_boundary.py` (extension operation-metadata import boundary enforcement),
   - `tests/test_extension_operation_metadata_usage.py` (extension manager operation-metadata usage enforcement),
   - `tests/test_extension_parse_usage_boundary.py` (centralized extension list parse-helper usage boundary enforcement),

tests/test_architecture_marker_usage.py

@@ -108,6 +108,7 @@
     "tests/test_extension_operation_metadata_usage.py",
     "tests/test_extension_parse_usage_boundary.py",
     "tests/test_extension_key_display_helper_usage.py",
+    "tests/test_extension_key_display_import_boundary.py",
     "tests/test_extension_request_function_parse_boundary.py",
     "tests/test_extension_request_helper_usage.py",
     "tests/test_extension_request_internal_reuse.py",

tests/test_display_utils_import_boundary.py

@@ -13,6 +13,7 @@
 EXPECTED_EXTRA_IMPORTERS = (
     "tests/test_display_utils.py",
     "tests/test_display_utils_import_boundary.py",
+    "tests/test_extension_key_display_import_boundary.py",
 )
 
 

tests/test_extension_key_display_import_boundary.py

@@ -0,0 +1,26 @@
+import ast
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.architecture
+
+
+EXTENSION_UTILS_MODULE = Path("hyperbrowser/client/managers/extension_utils.py")
+
+
+def _imports_format_string_key_for_error(module_text: str) -> bool:
+    module_ast = ast.parse(module_text)
+    for node in module_ast.body:
+        if not isinstance(node, ast.ImportFrom):
+            continue
+        if node.module != "hyperbrowser.display_utils":
+            continue
+        if any(alias.name == "format_string_key_for_error" for alias in node.names):
+            return True
+    return False
+
+
+def test_extension_key_display_helper_is_imported_from_display_utils():
+    module_text = EXTENSION_UTILS_MODULE.read_text(encoding="utf-8")
+    assert _imports_format_string_key_for_error(module_text)