Wrap invalid extension file_path state access

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/extension.py

@@ -14,7 +14,15 @@ def __init__(self, client):
     async def create(self, params: CreateExtensionParams) -> ExtensionResponse:
         if not isinstance(params, CreateExtensionParams):
             raise HyperbrowserError("params must be CreateExtensionParams")
-        raw_file_path = params.file_path
+        try:
+            raw_file_path = params.file_path
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "params.file_path is invalid",
+                original_error=exc,
+            ) from exc
         payload = params.model_dump(exclude_none=True, by_alias=True)
         payload.pop("filePath", None)
 

hyperbrowser/client/managers/sync_manager/extension.py

@@ -14,7 +14,15 @@ def __init__(self, client):
     def create(self, params: CreateExtensionParams) -> ExtensionResponse:
         if not isinstance(params, CreateExtensionParams):
             raise HyperbrowserError("params must be CreateExtensionParams")
-        raw_file_path = params.file_path
+        try:
+            raw_file_path = params.file_path
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "params.file_path is invalid",
+                original_error=exc,
+            ) from exc
         payload = params.model_dump(exclude_none=True, by_alias=True)
         payload.pop("filePath", None)
 

tests/test_extension_manager.py

@@ -221,6 +221,48 @@ def test_sync_extension_create_rejects_invalid_params_type():
         manager.create({"name": "bad", "filePath": "/tmp/ext.zip"})  # type: ignore[arg-type]
 
 
+def test_sync_extension_create_wraps_invalid_params_file_path_state(tmp_path):
+    class _BrokenParams(CreateExtensionParams):
+        def __getattribute__(self, item: str):
+            if item == "file_path":
+                raise RuntimeError("broken file_path state")
+            return super().__getattribute__(item)
+
+    manager = SyncExtensionManager(_FakeClient(_SyncTransport()))
+    params = _BrokenParams(
+        name="bad-extension",
+        file_path=_create_test_extension_zip(tmp_path),
+    )
+
+    with pytest.raises(
+        HyperbrowserError, match="params.file_path is invalid"
+    ) as exc_info:
+        manager.create(params)
+
+    assert isinstance(exc_info.value.original_error, RuntimeError)
+
+
+def test_sync_extension_create_preserves_hyperbrowser_file_path_state_errors(tmp_path):
+    class _BrokenParams(CreateExtensionParams):
+        def __getattribute__(self, item: str):
+            if item == "file_path":
+                raise HyperbrowserError("custom file_path state failure")
+            return super().__getattribute__(item)
+
+    manager = SyncExtensionManager(_FakeClient(_SyncTransport()))
+    params = _BrokenParams(
+        name="bad-extension",
+        file_path=_create_test_extension_zip(tmp_path),
+    )
+
+    with pytest.raises(
+        HyperbrowserError, match="custom file_path state failure"
+    ) as exc_info:
+        manager.create(params)
+
+    assert exc_info.value.original_error is None
+
+
 def test_async_extension_list_raises_for_invalid_payload_shape():
     class _InvalidAsyncTransport:
         async def get(self, url, params=None, follow_redirects=False):
@@ -249,3 +291,49 @@ async def run():
             )
 
     asyncio.run(run())
+
+
+def test_async_extension_create_wraps_invalid_params_file_path_state(tmp_path):
+    class _BrokenParams(CreateExtensionParams):
+        def __getattribute__(self, item: str):
+            if item == "file_path":
+                raise RuntimeError("broken file_path state")
+            return super().__getattribute__(item)
+
+    manager = AsyncExtensionManager(_FakeClient(_AsyncTransport()))
+    params = _BrokenParams(
+        name="bad-extension",
+        file_path=_create_test_extension_zip(tmp_path),
+    )
+
+    async def run():
+        with pytest.raises(
+            HyperbrowserError, match="params.file_path is invalid"
+        ) as exc_info:
+            await manager.create(params)
+        assert isinstance(exc_info.value.original_error, RuntimeError)
+
+    asyncio.run(run())
+
+
+def test_async_extension_create_preserves_hyperbrowser_file_path_state_errors(tmp_path):
+    class _BrokenParams(CreateExtensionParams):
+        def __getattribute__(self, item: str):
+            if item == "file_path":
+                raise HyperbrowserError("custom file_path state failure")
+            return super().__getattribute__(item)
+
+    manager = AsyncExtensionManager(_FakeClient(_AsyncTransport()))
+    params = _BrokenParams(
+        name="bad-extension",
+        file_path=_create_test_extension_zip(tmp_path),
+    )
+
+    async def run():
+        with pytest.raises(
+            HyperbrowserError, match="custom file_path state failure"
+        ) as exc_info:
+            await manager.create(params)
+        assert exc_info.value.original_error is None
+
+    asyncio.run(run())