Treat HTTP 408 as retryable in polling helpers

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -15,7 +15,7 @@
 _MAX_OPERATION_NAME_LENGTH = 200
 _CLIENT_ERROR_STATUS_MIN = 400
 _CLIENT_ERROR_STATUS_MAX = 500
-_RETRYABLE_CLIENT_ERROR_STATUS_CODES = {429}
+_RETRYABLE_CLIENT_ERROR_STATUS_CODES = {408, 429}
 
 
 class _NonRetryablePollingError(HyperbrowserError):

tests/test_polling.py

@@ -182,6 +182,28 @@ def get_status() -> str:
     assert attempts["count"] == 3
 
 
+def test_poll_until_terminal_status_retries_request_timeout_errors():
+    attempts = {"count": 0}
+
+    def get_status() -> str:
+        attempts["count"] += 1
+        if attempts["count"] < 3:
+            raise HyperbrowserError("request timeout", status_code=408)
+        return "completed"
+
+    status = poll_until_terminal_status(
+        operation_name="sync poll request-timeout retries",
+        get_status=get_status,
+        is_terminal_status=lambda value: value == "completed",
+        poll_interval_seconds=0.0001,
+        max_wait_seconds=1.0,
+        max_status_failures=5,
+    )
+
+    assert status == "completed"
+    assert attempts["count"] == 3
+
+
 def test_poll_until_terminal_status_async_retries_rate_limit_errors():
     async def run() -> None:
         attempts = {"count": 0}
@@ -207,6 +229,31 @@ async def get_status() -> str:
     asyncio.run(run())
 
 
+def test_poll_until_terminal_status_async_retries_request_timeout_errors():
+    async def run() -> None:
+        attempts = {"count": 0}
+
+        async def get_status() -> str:
+            attempts["count"] += 1
+            if attempts["count"] < 3:
+                raise HyperbrowserError("request timeout", status_code=408)
+            return "completed"
+
+        status = await poll_until_terminal_status_async(
+            operation_name="async poll request-timeout retries",
+            get_status=get_status,
+            is_terminal_status=lambda value: value == "completed",
+            poll_interval_seconds=0.0001,
+            max_wait_seconds=1.0,
+            max_status_failures=5,
+        )
+
+        assert status == "completed"
+        assert attempts["count"] == 3
+
+    asyncio.run(run())
+
+
 def test_poll_until_terminal_status_async_handles_non_integer_status_codes_as_retryable():
     async def run() -> None:
         attempts = {"count": 0}
@@ -437,6 +484,26 @@ def operation() -> str:
     assert attempts["count"] == 3
 
 
+def test_retry_operation_retries_request_timeout_errors():
+    attempts = {"count": 0}
+
+    def operation() -> str:
+        attempts["count"] += 1
+        if attempts["count"] < 3:
+            raise HyperbrowserError("request timeout", status_code=408)
+        return "ok"
+
+    result = retry_operation(
+        operation_name="sync retry request-timeout error",
+        operation=operation,
+        max_attempts=5,
+        retry_delay_seconds=0.0001,
+    )
+
+    assert result == "ok"
+    assert attempts["count"] == 3
+
+
 def test_retry_operation_handles_non_integer_status_codes_as_retryable():
     attempts = {"count": 0}
 
@@ -748,6 +815,29 @@ async def operation() -> str:
     asyncio.run(run())
 
 
+def test_retry_operation_async_retries_request_timeout_errors():
+    async def run() -> None:
+        attempts = {"count": 0}
+
+        async def operation() -> str:
+            attempts["count"] += 1
+            if attempts["count"] < 3:
+                raise HyperbrowserError("request timeout", status_code=408)
+            return "ok"
+
+        result = await retry_operation_async(
+            operation_name="async retry request-timeout error",
+            operation=operation,
+            max_attempts=5,
+            retry_delay_seconds=0.0001,
+        )
+
+        assert result == "ok"
+        assert attempts["count"] == 3
+
+    asyncio.run(run())
+
+
 def test_async_poll_until_terminal_status_allows_immediate_terminal_on_zero_max_wait():
     async def run() -> None:
         status = await poll_until_terminal_status_async(