Support bytes response text in transport fallback extraction

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/error_utils.py

@@ -142,6 +142,17 @@ def _truncate_error_message(message: str) -> str:
     return f"{sanitized_message[:_MAX_ERROR_MESSAGE_LENGTH]}... (truncated)"
 
 
+def _normalize_response_text_for_error_message(response_text: Any) -> str:
+    if isinstance(response_text, str):
+        return response_text
+    if isinstance(response_text, (bytes, bytearray, memoryview)):
+        try:
+            return memoryview(response_text).tobytes().decode("utf-8")
+        except (TypeError, ValueError, UnicodeDecodeError):
+            return ""
+    return _safe_to_string(response_text)
+
+
 def _stringify_error_value(value: Any, *, _depth: int = 0) -> str:
     if _depth > 10:
         return _safe_to_string(value)
@@ -191,7 +202,7 @@ def _stringify_error_value(value: Any, *, _depth: int = 0) -> str:
 def extract_error_message(response: httpx.Response, fallback_error: Exception) -> str:
     def _fallback_message() -> str:
         try:
-            response_text = response.text
+            response_text = _normalize_response_text_for_error_message(response.text)
         except Exception:
             response_text = ""
         if isinstance(response_text, str) and response_text.strip():

tests/test_transport_error_utils.py

@@ -173,6 +173,18 @@ def json(self):
         raise ValueError("invalid json")
 
 
+class _BytesFallbackResponse:
+    def __init__(self, response_text: bytes) -> None:
+        self._response_text = response_text
+
+    @property
+    def text(self) -> bytes:
+        return self._response_text
+
+    def json(self):
+        raise ValueError("invalid json")
+
+
 class _BrokenGetErrorDict(dict):
     def get(self, key, default=None):
         _ = key
@@ -734,6 +746,24 @@ def test_extract_error_message_uses_response_text_for_blank_string_payload():
     assert message == "raw error body"
 
 
+def test_extract_error_message_uses_utf8_bytes_response_text_fallback():
+    message = extract_error_message(
+        _BytesFallbackResponse("raw bytes body".encode("utf-8")),  # type: ignore[arg-type]
+        RuntimeError("fallback detail"),
+    )
+
+    assert message == "raw bytes body"
+
+
+def test_extract_error_message_uses_fallback_for_invalid_bytes_response_text():
+    message = extract_error_message(
+        _BytesFallbackResponse(b"\xff\xfe"),  # type: ignore[arg-type]
+        RuntimeError("fallback detail"),
+    )
+
+    assert message == "fallback detail"
+
+
 def test_extract_error_message_uses_fallback_error_when_response_text_is_blank():
     message = extract_error_message(
         _DummyResponse("   ", text="   "),