Skip to content

Commit 7390f33

Browse files
Broaden generic transport failure method typing to object
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent 57c3ec6 commit 7390f33

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

hyperbrowser/transport/error_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def format_request_failure_message(
148148
return f"Request {effective_method} {effective_url} failed"
149149

150150

151-
def format_generic_request_failure_message(*, method: str, url: object) -> str:
151+
def format_generic_request_failure_message(*, method: object, url: object) -> str:
152152
normalized_method = _normalize_request_method(method)
153153
normalized_url = _normalize_request_url(url)
154154
return f"Request {normalized_method} {normalized_url} failed"

tests/test_transport_error_utils.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,15 @@ def test_format_generic_request_failure_message_normalizes_invalid_method_values
253253
assert message == "Request UNKNOWN https://example.com/path failed"
254254

255255

256+
def test_format_generic_request_failure_message_normalizes_non_string_method_values():
257+
message = format_generic_request_failure_message(
258+
method=123,
259+
url="https://example.com/path",
260+
)
261+
262+
assert message == "Request UNKNOWN https://example.com/path failed"
263+
264+
256265
def test_format_request_failure_message_truncates_very_long_fallback_urls():
257266
very_long_url = "https://example.com/" + ("a" * 1200)
258267
message = format_request_failure_message(

0 commit comments

Comments
 (0)