Harden request-error context extraction against malformed errors

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/error_utils.py

@@ -38,11 +38,24 @@ def extract_error_message(response: httpx.Response, fallback_error: Exception) -
 def extract_request_error_context(error: httpx.RequestError) -> tuple[str, str]:
     try:
         request = error.request
-    except RuntimeError:
+    except Exception:
         request = None
     if request is None:
         return "UNKNOWN", "unknown URL"
-    return request.method, str(request.url)
+    try:
+        request_method = request.method
+    except Exception:
+        request_method = "UNKNOWN"
+    if not isinstance(request_method, str) or not request_method.strip():
+        request_method = "UNKNOWN"
+
+    try:
+        request_url = str(request.url)
+    except Exception:
+        request_url = "unknown URL"
+    if not request_url.strip():
+        request_url = "unknown URL"
+    return request_method, request_url
 
 
 def format_request_failure_message(

tests/test_transport_error_utils.py

@@ -0,0 +1,94 @@
+import httpx
+
+from hyperbrowser.transport.error_utils import (
+    extract_request_error_context,
+    format_request_failure_message,
+)
+
+
+class _BrokenRequest:
+    @property
+    def method(self) -> str:
+        raise ValueError("missing method")
+
+    @property
+    def url(self) -> str:
+        raise ValueError("missing url")
+
+
+class _BlankContextRequest:
+    method = "   "
+    url = "   "
+
+
+class _RequestErrorWithFailingRequestProperty(httpx.RequestError):
+    @property
+    def request(self):  # type: ignore[override]
+        raise ValueError("broken request property")
+
+
+class _RequestErrorWithBrokenRequest(httpx.RequestError):
+    @property
+    def request(self):  # type: ignore[override]
+        return _BrokenRequest()
+
+
+class _RequestErrorWithBlankContext(httpx.RequestError):
+    @property
+    def request(self):  # type: ignore[override]
+        return _BlankContextRequest()
+
+
+def test_extract_request_error_context_uses_unknown_when_request_unset():
+    method, url = extract_request_error_context(httpx.RequestError("network down"))
+
+    assert method == "UNKNOWN"
+    assert url == "unknown URL"
+
+
+def test_extract_request_error_context_handles_request_property_failures():
+    method, url = extract_request_error_context(
+        _RequestErrorWithFailingRequestProperty("network down")
+    )
+
+    assert method == "UNKNOWN"
+    assert url == "unknown URL"
+
+
+def test_extract_request_error_context_handles_broken_request_attributes():
+    method, url = extract_request_error_context(
+        _RequestErrorWithBrokenRequest("network down")
+    )
+
+    assert method == "UNKNOWN"
+    assert url == "unknown URL"
+
+
+def test_extract_request_error_context_normalizes_blank_method_and_url():
+    method, url = extract_request_error_context(
+        _RequestErrorWithBlankContext("network down")
+    )
+
+    assert method == "UNKNOWN"
+    assert url == "unknown URL"
+
+
+def test_format_request_failure_message_uses_fallback_values():
+    message = format_request_failure_message(
+        httpx.RequestError("network down"),
+        fallback_method="GET",
+        fallback_url="https://example.com/fallback",
+    )
+
+    assert message == "Request GET https://example.com/fallback failed"
+
+
+def test_format_request_failure_message_prefers_request_context():
+    request = httpx.Request("POST", "https://example.com/actual")
+    message = format_request_failure_message(
+        httpx.RequestError("network down", request=request),
+        fallback_method="GET",
+        fallback_url="https://example.com/fallback",
+    )
+
+    assert message == "Request POST https://example.com/actual failed"