Reject closed file-like objects in session uploads

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/session.py

@@ -134,6 +134,8 @@ async def upload_file(
                     original_error=exc,
                 ) from exc
         elif callable(getattr(file_input, "read", None)):
+            if getattr(file_input, "closed", False):
+                raise HyperbrowserError("file_input file-like object must be open")
             files = {"file": file_input}
             response = await self._client.transport.post(
                 self._client._build_url(f"/session/{id}/uploads"),

hyperbrowser/client/managers/sync_manager/session.py

@@ -126,6 +126,8 @@ def upload_file(
                     original_error=exc,
                 ) from exc
         elif callable(getattr(file_input, "read", None)):
+            if getattr(file_input, "closed", False):
+                raise HyperbrowserError("file_input file-like object must be open")
             files = {"file": file_input}
             response = self._client.transport.post(
                 self._client._build_url(f"/session/{id}/uploads"),

tests/test_session_upload_file.py

@@ -148,6 +148,15 @@ def test_sync_session_upload_file_rejects_non_callable_read_attribute():
         manager.upload_file("session_123", fake_file)
 
 
+def test_sync_session_upload_file_rejects_closed_file_like_object():
+    manager = SyncSessionManager(_FakeClient(_SyncTransport()))
+    closed_file_obj = io.BytesIO(b"content")
+    closed_file_obj.close()
+
+    with pytest.raises(HyperbrowserError, match="file-like object must be open"):
+        manager.upload_file("session_123", closed_file_obj)
+
+
 def test_async_session_upload_file_rejects_non_callable_read_attribute():
     manager = AsyncSessionManager(_FakeClient(_AsyncTransport()))
     fake_file = type("FakeFile", (), {"read": "not-callable"})()
@@ -159,6 +168,18 @@ async def run():
     asyncio.run(run())
 
 
+def test_async_session_upload_file_rejects_closed_file_like_object():
+    manager = AsyncSessionManager(_FakeClient(_AsyncTransport()))
+    closed_file_obj = io.BytesIO(b"content")
+    closed_file_obj.close()
+
+    async def run():
+        with pytest.raises(HyperbrowserError, match="file-like object must be open"):
+            await manager.upload_file("session_123", closed_file_obj)
+
+    asyncio.run(run())
+
+
 def test_sync_session_upload_file_raises_hyperbrowser_error_for_missing_path(tmp_path):
     manager = SyncSessionManager(_FakeClient(_SyncTransport()))
     missing_path = tmp_path / "missing-file.txt"