Wrap finite-check failures with original error context

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -89,8 +89,11 @@ def _normalize_non_negative_real(value: float, *, field_name: str) -> float:
         ) from exc
     try:
         is_finite = math.isfinite(normalized_value)
-    except (TypeError, ValueError, OverflowError):
-        is_finite = False
+    except (TypeError, ValueError, OverflowError) as exc:
+        raise HyperbrowserError(
+            f"{field_name} must be finite",
+            original_error=exc,
+        ) from exc
     if not is_finite:
         raise HyperbrowserError(f"{field_name} must be finite")
     if normalized_value < 0:

hyperbrowser/client/timeout_utils.py

@@ -23,8 +23,11 @@ def validate_timeout_seconds(timeout: Optional[float]) -> Optional[float]:
         ) from exc
     try:
         is_finite = math.isfinite(normalized_timeout)
-    except (TypeError, ValueError, OverflowError):
-        is_finite = False
+    except (TypeError, ValueError, OverflowError) as exc:
+        raise HyperbrowserError(
+            "timeout must be finite",
+            original_error=exc,
+        ) from exc
     if not is_finite:
         raise HyperbrowserError("timeout must be finite")
     if normalized_timeout < 0:

tests/test_client_timeout.py

@@ -5,6 +5,7 @@
 
 import pytest
 
+import hyperbrowser.client.timeout_utils as timeout_helpers
 from hyperbrowser import AsyncHyperbrowser, Hyperbrowser
 from hyperbrowser.exceptions import HyperbrowserError
 
@@ -130,3 +131,33 @@ def test_async_client_rejects_overflowing_real_timeout():
         AsyncHyperbrowser(api_key="test-key", timeout=Fraction(10**1000, 1))
 
     assert exc_info.value.original_error is not None
+
+
+def test_sync_client_wraps_timeout_isfinite_failures(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    def _raise_isfinite_error(value: float) -> bool:
+        _ = value
+        raise OverflowError("finite check overflow")
+
+    monkeypatch.setattr(timeout_helpers.math, "isfinite", _raise_isfinite_error)
+
+    with pytest.raises(HyperbrowserError, match="timeout must be finite") as exc_info:
+        Hyperbrowser(api_key="test-key", timeout=1)
+
+    assert exc_info.value.original_error is not None
+
+
+def test_async_client_wraps_timeout_isfinite_failures(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    def _raise_isfinite_error(value: float) -> bool:
+        _ = value
+        raise OverflowError("finite check overflow")
+
+    monkeypatch.setattr(timeout_helpers.math, "isfinite", _raise_isfinite_error)
+
+    with pytest.raises(HyperbrowserError, match="timeout must be finite") as exc_info:
+        AsyncHyperbrowser(api_key="test-key", timeout=1)
+
+    assert exc_info.value.original_error is not None

tests/test_polling.py

@@ -43,6 +43,30 @@ def test_poll_until_terminal_status_returns_terminal_value():
     assert status == "completed"
 
 
+def test_poll_until_terminal_status_wraps_isfinite_failures(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    def _raise_isfinite_error(value: float) -> bool:
+        _ = value
+        raise OverflowError("finite check overflow")
+
+    monkeypatch.setattr(polling_helpers.math, "isfinite", _raise_isfinite_error)
+
+    with pytest.raises(
+        HyperbrowserError,
+        match="poll_interval_seconds must be finite",
+    ) as exc_info:
+        poll_until_terminal_status(
+            operation_name="sync poll finite check",
+            get_status=lambda: "completed",
+            is_terminal_status=lambda value: value == "completed",
+            poll_interval_seconds=0.1,
+            max_wait_seconds=1.0,
+        )
+
+    assert exc_info.value.original_error is not None
+
+
 def test_build_fetch_operation_name_prefixes_when_within_length_limit():
     assert build_fetch_operation_name("crawl job 123") == "Fetching crawl job 123"