Support URL-like fallback objects in transport failure formatting

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/error_utils.py

@@ -22,9 +22,16 @@ def _normalize_request_method(method: Any) -> str:
 
 
 def _normalize_request_url(url: Any) -> str:
-    if not isinstance(url, str):
+    if url is None:
         return "unknown URL"
-    normalized_url = url.strip()
+    raw_url = url
+    if not isinstance(raw_url, str):
+        try:
+            raw_url = str(raw_url)
+        except Exception:
+            return "unknown URL"
+
+    normalized_url = raw_url.strip()
     if not normalized_url:
         return "unknown URL"
     if any(character.isspace() for character in normalized_url):

tests/test_transport_error_utils.py

@@ -245,6 +245,16 @@ def test_format_request_failure_message_normalizes_non_string_fallback_values():
     assert message == "Request UNKNOWN unknown URL failed"
 
 
+def test_format_request_failure_message_supports_url_like_fallback_values():
+    message = format_request_failure_message(
+        httpx.RequestError("network down"),
+        fallback_method="GET",
+        fallback_url=httpx.URL("https://example.com/fallback"),
+    )
+
+    assert message == "Request GET https://example.com/fallback failed"
+
+
 def test_format_generic_request_failure_message_normalizes_invalid_url_objects():
     message = format_generic_request_failure_message(
         method="GET",
@@ -254,6 +264,15 @@ def test_format_generic_request_failure_message_normalizes_invalid_url_objects()
     assert message == "Request GET unknown URL failed"
 
 
+def test_format_generic_request_failure_message_supports_url_like_values():
+    message = format_generic_request_failure_message(
+        method="GET",
+        url=httpx.URL("https://example.com/path"),
+    )
+
+    assert message == "Request GET https://example.com/path failed"
+
+
 def test_format_generic_request_failure_message_normalizes_invalid_method_values():
     message = format_generic_request_failure_message(
         method="GET /invalid",

tests/test_transport_response_handling.py

@@ -439,6 +439,24 @@ def failing_get(*args, **kwargs):
         transport.close()
 
 
+def test_sync_transport_request_error_without_request_uses_url_like_fallback():
+    transport = SyncTransport(api_key="test-key")
+    original_get = transport.client.get
+
+    def failing_get(*args, **kwargs):
+        raise httpx.RequestError("network down")
+
+    transport.client.get = failing_get  # type: ignore[assignment]
+    try:
+        with pytest.raises(
+            HyperbrowserError, match="Request GET https://example.com/fallback failed"
+        ):
+            transport.get(httpx.URL("https://example.com/fallback"))  # type: ignore[arg-type]
+    finally:
+        transport.client.get = original_get  # type: ignore[assignment]
+        transport.close()
+
+
 def test_sync_transport_request_error_without_request_uses_unknown_url_for_invalid_input():
     transport = SyncTransport(api_key="test-key")
     original_get = transport.client.get
@@ -477,6 +495,28 @@ async def failing_delete(*args, **kwargs):
     asyncio.run(run())
 
 
+def test_async_transport_request_error_without_request_uses_url_like_fallback():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        original_delete = transport.client.delete
+
+        async def failing_delete(*args, **kwargs):
+            raise httpx.RequestError("network down")
+
+        transport.client.delete = failing_delete  # type: ignore[assignment]
+        try:
+            with pytest.raises(
+                HyperbrowserError,
+                match="Request DELETE https://example.com/fallback failed",
+            ):
+                await transport.delete(httpx.URL("https://example.com/fallback"))  # type: ignore[arg-type]
+        finally:
+            transport.client.delete = original_delete  # type: ignore[assignment]
+            await transport.close()
+
+    asyncio.run(run())
+
+
 def test_async_transport_request_error_without_request_uses_unknown_url_for_invalid_input():
     async def run() -> None:
         transport = AsyncTransport(api_key="test-key")