Share default terminal-status predicate for polling jobs

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -86,6 +86,7 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_contributing_architecture_guard_listing.py` (`CONTRIBUTING.md` architecture-guard inventory completeness enforcement),
   - `tests/test_core_type_helper_usage.py` (core transport/config/header/file/polling/session/error/parsing manager+tool module enforcement of shared plain-type helper usage),
   - `tests/test_default_serialization_helper_usage.py` (default optional-query serialization helper usage enforcement),
+  - `tests/test_default_terminal_status_helper_usage.py` (default terminal-status helper usage enforcement for non-agent managers),
   - `tests/test_display_helper_usage.py` (display/key-format helper usage),
   - `tests/test_docs_python3_commands.py` (`README`/`CONTRIBUTING`/examples python3 command consistency enforcement),
   - `tests/test_example_run_instructions.py` (example run-instruction consistency enforcement),

hyperbrowser/client/managers/async_manager/crawl.py

@@ -12,6 +12,7 @@
     build_job_paginated_page_merge_callback,
     initialize_job_paginated_response,
 )
+from ..job_status_utils import is_default_terminal_job_status
 from ..serialization_utils import (
     serialize_model_dump_or_default,
     serialize_model_dump_to_dict,
@@ -92,7 +93,7 @@ async def start_and_wait(
         job_status = await poll_until_terminal_status_async(
             operation_name=operation_name,
             get_status=lambda: self.get_status(job_id).status,
-            is_terminal_status=lambda status: status in {"completed", "failed"},
+            is_terminal_status=is_default_terminal_job_status,
             poll_interval_seconds=poll_interval_seconds,
             max_wait_seconds=max_wait_seconds,
             max_status_failures=max_status_failures,

hyperbrowser/client/managers/async_manager/extract.py

@@ -8,6 +8,7 @@
     StartExtractJobResponse,
 )
 from ..extract_payload_utils import build_extract_start_payload
+from ..job_status_utils import is_default_terminal_job_status
 from ..start_job_utils import build_started_job_context
 from ...polling import wait_for_job_result_async
 from ..response_utils import parse_response_model
@@ -67,7 +68,7 @@ async def start_and_wait(
         return await wait_for_job_result_async(
             operation_name=operation_name,
             get_status=lambda: self.get_status(job_id).status,
-            is_terminal_status=lambda status: status in {"completed", "failed"},
+            is_terminal_status=is_default_terminal_job_status,
             fetch_result=lambda: self.get(job_id),
             poll_interval_seconds=poll_interval_seconds,
             max_wait_seconds=max_wait_seconds,

hyperbrowser/client/managers/async_manager/scrape.py

@@ -13,6 +13,7 @@
     build_job_paginated_page_merge_callback,
     initialize_job_paginated_response,
 )
+from ..job_status_utils import is_default_terminal_job_status
 from ..serialization_utils import (
     serialize_model_dump_or_default,
     serialize_model_dump_to_dict,
@@ -99,7 +100,7 @@ async def start_and_wait(
         job_status = await poll_until_terminal_status_async(
             operation_name=operation_name,
             get_status=lambda: self.get_status(job_id).status,
-            is_terminal_status=lambda status: status in {"completed", "failed"},
+            is_terminal_status=is_default_terminal_job_status,
             poll_interval_seconds=poll_interval_seconds,
             max_wait_seconds=max_wait_seconds,
             max_status_failures=max_status_failures,
@@ -204,7 +205,7 @@ async def start_and_wait(
         return await wait_for_job_result_async(
             operation_name=operation_name,
             get_status=lambda: self.get_status(job_id).status,
-            is_terminal_status=lambda status: status in {"completed", "failed"},
+            is_terminal_status=is_default_terminal_job_status,
             fetch_result=lambda: self.get(job_id),
             poll_interval_seconds=poll_interval_seconds,
             max_wait_seconds=max_wait_seconds,

hyperbrowser/client/managers/async_manager/web/batch_fetch.py

@@ -9,6 +9,7 @@
     POLLING_ATTEMPTS,
 )
 from ...page_params_utils import build_page_batch_params
+from ...job_status_utils import is_default_terminal_job_status
 from ...web_payload_utils import build_batch_fetch_start_payload
 from ...web_payload_utils import build_batch_fetch_get_params
 from ...web_pagination_utils import (
@@ -86,7 +87,7 @@ async def start_and_wait(
         job_status = await poll_until_terminal_status_async(
             operation_name=operation_name,
             get_status=lambda: self.get_status(job_id).status,
-            is_terminal_status=lambda status: status in {"completed", "failed"},
+            is_terminal_status=is_default_terminal_job_status,
             poll_interval_seconds=poll_interval_seconds,
             max_wait_seconds=max_wait_seconds,
             max_status_failures=max_status_failures,

hyperbrowser/client/managers/async_manager/web/crawl.py

@@ -9,6 +9,7 @@
     POLLING_ATTEMPTS,
 )
 from ...page_params_utils import build_page_batch_params
+from ...job_status_utils import is_default_terminal_job_status
 from ...web_payload_utils import build_web_crawl_start_payload
 from ...web_payload_utils import build_web_crawl_get_params
 from ...web_pagination_utils import (
@@ -84,7 +85,7 @@ async def start_and_wait(
         job_status = await poll_until_terminal_status_async(
             operation_name=operation_name,
             get_status=lambda: self.get_status(job_id).status,
-            is_terminal_status=lambda status: status in {"completed", "failed"},
+            is_terminal_status=is_default_terminal_job_status,
             poll_interval_seconds=poll_interval_seconds,
             max_wait_seconds=max_wait_seconds,
             max_status_failures=max_status_failures,

hyperbrowser/client/managers/job_status_utils.py

@@ -0,0 +1,7 @@
+from typing import FrozenSet
+
+DEFAULT_TERMINAL_JOB_STATUSES: FrozenSet[str] = frozenset({"completed", "failed"})
+
+
+def is_default_terminal_job_status(status: str) -> bool:
+    return status in DEFAULT_TERMINAL_JOB_STATUSES

hyperbrowser/client/managers/sync_manager/crawl.py

@@ -12,6 +12,7 @@
     build_job_paginated_page_merge_callback,
     initialize_job_paginated_response,
 )
+from ..job_status_utils import is_default_terminal_job_status
 from ..serialization_utils import (
     serialize_model_dump_or_default,
     serialize_model_dump_to_dict,
@@ -92,7 +93,7 @@ def start_and_wait(
         job_status = poll_until_terminal_status(
             operation_name=operation_name,
             get_status=lambda: self.get_status(job_id).status,
-            is_terminal_status=lambda status: status in {"completed", "failed"},
+            is_terminal_status=is_default_terminal_job_status,
             poll_interval_seconds=poll_interval_seconds,
             max_wait_seconds=max_wait_seconds,
             max_status_failures=max_status_failures,

hyperbrowser/client/managers/sync_manager/extract.py

@@ -8,6 +8,7 @@
     StartExtractJobResponse,
 )
 from ..extract_payload_utils import build_extract_start_payload
+from ..job_status_utils import is_default_terminal_job_status
 from ..start_job_utils import build_started_job_context
 from ...polling import wait_for_job_result
 from ..response_utils import parse_response_model
@@ -67,7 +68,7 @@ def start_and_wait(
         return wait_for_job_result(
             operation_name=operation_name,
             get_status=lambda: self.get_status(job_id).status,
-            is_terminal_status=lambda status: status in {"completed", "failed"},
+            is_terminal_status=is_default_terminal_job_status,
             fetch_result=lambda: self.get(job_id),
             poll_interval_seconds=poll_interval_seconds,
             max_wait_seconds=max_wait_seconds,

hyperbrowser/client/managers/sync_manager/scrape.py

@@ -13,6 +13,7 @@
     build_job_paginated_page_merge_callback,
     initialize_job_paginated_response,
 )
+from ..job_status_utils import is_default_terminal_job_status
 from ..serialization_utils import (
     serialize_model_dump_or_default,
     serialize_model_dump_to_dict,
@@ -97,7 +98,7 @@ def start_and_wait(
         job_status = poll_until_terminal_status(
             operation_name=operation_name,
             get_status=lambda: self.get_status(job_id).status,
-            is_terminal_status=lambda status: status in {"completed", "failed"},
+            is_terminal_status=is_default_terminal_job_status,
             poll_interval_seconds=poll_interval_seconds,
             max_wait_seconds=max_wait_seconds,
             max_status_failures=max_status_failures,
@@ -202,7 +203,7 @@ def start_and_wait(
         return wait_for_job_result(
             operation_name=operation_name,
             get_status=lambda: self.get_status(job_id).status,
-            is_terminal_status=lambda status: status in {"completed", "failed"},
+            is_terminal_status=is_default_terminal_job_status,
             fetch_result=lambda: self.get(job_id),
             poll_interval_seconds=poll_interval_seconds,
             max_wait_seconds=max_wait_seconds,