Reject string-subclass tool response text values

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/tools/__init__.py

@@ -146,7 +146,7 @@ def _to_param_dict(params: Mapping[str, Any]) -> Dict[str, Any]:
         if type(key) is str:
             try:
                 normalized_key = key.strip()
-                if not isinstance(normalized_key, str):
+                if type(normalized_key) is not str:
                     raise TypeError("normalized tool param key must be a string")
                 is_empty_key = len(normalized_key) == 0
             except HyperbrowserError:
@@ -227,7 +227,7 @@ def _normalize_optional_text_field_value(
 ) -> str:
     if field_value is None:
         return ""
-    if isinstance(field_value, str):
+    if type(field_value) is str:
         try:
             normalized_field_value = "".join(character for character in field_value)
             if type(normalized_field_value) is not str:
@@ -240,6 +240,8 @@ def _normalize_optional_text_field_value(
                 error_message,
                 original_error=exc,
             ) from exc
+    if isinstance(field_value, str):
+        raise HyperbrowserError(error_message)
     if isinstance(field_value, (bytes, bytearray, memoryview)):
         try:
             normalized_field_value = memoryview(field_value).tobytes().decode("utf-8")

tests/test_tools_response_handling.py

@@ -351,7 +351,7 @@ def __iter__(self):
     ) as exc_info:
         WebsiteScrapeTool.runnable(client, {"url": "https://example.com"})
 
-    assert exc_info.value.original_error is not None
+    assert exc_info.value.original_error is None
 
 
 def test_scrape_tool_wraps_attributeerror_from_declared_markdown_property():
@@ -758,7 +758,9 @@ def __getitem__(self, key: str) -> object:
 
     client = _SyncCrawlClient(_Response(data=[_BrokenContainsPage()]))
 
-    with pytest.raises(HyperbrowserError, match="custom page inspect failure") as exc_info:
+    with pytest.raises(
+        HyperbrowserError, match="custom page inspect failure"
+    ) as exc_info:
         WebsiteCrawlTool.runnable(client, {"url": "https://example.com"})
 
     assert exc_info.value.original_error is None
@@ -782,7 +784,13 @@ def __iter__(self):
             raise RuntimeError("url iteration exploded")
 
     client = _SyncCrawlClient(
-        _Response(data=[SimpleNamespace(url=_BrokenUrlValue("https://example.com"), markdown="body")])
+        _Response(
+            data=[
+                SimpleNamespace(
+                    url=_BrokenUrlValue("https://example.com"), markdown="body"
+                )
+            ]
+        )
     )
 
     with pytest.raises(
@@ -791,7 +799,7 @@ def __iter__(self):
     ) as exc_info:
         WebsiteCrawlTool.runnable(client, {"url": "https://example.com"})
 
-    assert exc_info.value.original_error is not None
+    assert exc_info.value.original_error is None
 
 
 def test_crawl_tool_decodes_utf8_bytes_page_fields():
@@ -870,7 +878,7 @@ def __iter__(self):
     ) as exc_info:
         BrowserUseTool.runnable(client, {"task": "search docs"})
 
-    assert exc_info.value.original_error is not None
+    assert exc_info.value.original_error is None
 
 
 def test_browser_use_tool_wraps_attributeerror_from_declared_final_result_property():