Include request method in low-level request error messages

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/async_transport.py

@@ -67,9 +67,10 @@ async def _handle_response(self, response: httpx.Response) -> APIResponse:
                 original_error=e,
             )
         except httpx.RequestError as e:
-            request_url = str(e.request.url) if e.request else "unknown URL"
+            request_method = e.request.method if e.request is not None else "UNKNOWN"
+            request_url = str(e.request.url) if e.request is not None else "unknown URL"
             raise HyperbrowserError(
-                f"Request failed for {request_url}", original_error=e
+                f"Request {request_method} {request_url} failed", original_error=e
             )
 
     async def post(

hyperbrowser/transport/sync.py

@@ -55,9 +55,10 @@ def _handle_response(self, response: httpx.Response) -> APIResponse:
                 original_error=e,
             )
         except httpx.RequestError as e:
-            request_url = str(e.request.url) if e.request else "unknown URL"
+            request_method = e.request.method if e.request is not None else "UNKNOWN"
+            request_url = str(e.request.url) if e.request is not None else "unknown URL"
             raise HyperbrowserError(
-                f"Request failed for {request_url}", original_error=e
+                f"Request {request_method} {request_url} failed", original_error=e
             )
 
     def close(self) -> None:

tests/test_transport_response_handling.py

@@ -13,6 +13,14 @@ def _build_response(status_code: int, body: str) -> httpx.Response:
     return httpx.Response(status_code, request=request, text=body)
 
 
+class _RequestErrorResponse:
+    def __init__(self, method: str, url: str) -> None:
+        self._request = httpx.Request(method, url)
+
+    def raise_for_status(self) -> None:
+        raise httpx.RequestError("network down", request=self._request)
+
+
 def test_sync_handle_response_with_non_json_success_body_returns_status_only():
     transport = SyncTransport(api_key="test-key")
     try:
@@ -26,6 +34,20 @@ def test_sync_handle_response_with_non_json_success_body_returns_status_only():
         transport.close()
 
 
+def test_sync_handle_response_with_request_error_includes_method_and_url():
+    transport = SyncTransport(api_key="test-key")
+    try:
+        with pytest.raises(
+            HyperbrowserError,
+            match="Request GET https://example.com/network failed",
+        ):
+            transport._handle_response(
+                _RequestErrorResponse("GET", "https://example.com/network")
+            )
+    finally:
+        transport.close()
+
+
 def test_async_handle_response_with_non_json_success_body_returns_status_only():
     async def run() -> None:
         transport = AsyncTransport(api_key="test-key")
@@ -42,6 +64,23 @@ async def run() -> None:
     asyncio.run(run())
 
 
+def test_async_handle_response_with_request_error_includes_method_and_url():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        try:
+            with pytest.raises(
+                HyperbrowserError,
+                match="Request POST https://example.com/network failed",
+            ):
+                await transport._handle_response(
+                    _RequestErrorResponse("POST", "https://example.com/network")
+                )
+        finally:
+            await transport.close()
+
+    asyncio.run(run())
+
+
 def test_sync_handle_response_with_error_and_non_json_body_raises_hyperbrowser_error():
     transport = SyncTransport(api_key="test-key")
     try: