Refactor extension key display through safe helper

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/extension_utils.py

@@ -3,6 +3,7 @@
 
 from hyperbrowser.display_utils import format_string_key_for_error
 from hyperbrowser.exceptions import HyperbrowserError
+from hyperbrowser.mapping_utils import safe_key_display_for_error
 from hyperbrowser.models.extension import ExtensionResponse
 from hyperbrowser.type_utils import is_plain_string
 from .list_parsing_utils import parse_mapping_list_items, read_plain_list_items
@@ -20,20 +21,30 @@ def _safe_stringify_key(value: object) -> str:
         normalized_key = str(value)
         if not is_plain_string(normalized_key):
             raise TypeError("normalized key must be a string")
-        return normalized_key
+        sanitized_key = "".join(
+            "?" if ord(character) < 32 or ord(character) == 127 else character
+            for character in normalized_key
+        )
+        if not is_plain_string(sanitized_key):
+            raise TypeError("sanitized key must be a string")
+        return sanitized_key
     except Exception:
         return f"<unprintable {_get_type_name(value)}>"
 
 
 def _format_key_display(value: object) -> str:
-    try:
-        normalized_key = _safe_stringify_key(value)
-        if not is_plain_string(normalized_key):
-            raise TypeError("normalized key display must be a string")
-    except Exception:
-        return "<unreadable key>"
-    return format_string_key_for_error(
+    normalized_key = _safe_stringify_key(value)
+    if not normalized_key.strip():
+        return format_string_key_for_error(
+            "",
+            max_length=_MAX_DISPLAYED_MISSING_KEY_LENGTH,
+        )
+    safe_key_text = safe_key_display_for_error(
         normalized_key,
+        key_display=lambda key: key,
+    )
+    return format_string_key_for_error(
+        safe_key_text,
         max_length=_MAX_DISPLAYED_MISSING_KEY_LENGTH,
     )
 

tests/test_mapping_utils_import_boundary.py

@@ -3,6 +3,7 @@
 
 import pytest
 
+from tests.test_safe_key_display_helper_usage import ALLOWED_SAFE_KEY_DISPLAY_CALL_FILES
 from tests.test_mapping_reader_usage import MAPPING_READER_TARGET_FILES
 from tests.test_tool_mapping_reader_usage import TOOLS_MODULE
 
@@ -37,7 +38,15 @@ def test_mapping_utils_imports_are_centralized():
             discovered_modules.append(module_path.as_posix())
 
     expected_runtime_modules = sorted(
-        [*(path.as_posix() for path in MAPPING_READER_TARGET_FILES), TOOLS_MODULE.as_posix()]
+        {
+            *(path.as_posix() for path in MAPPING_READER_TARGET_FILES),
+            TOOLS_MODULE.as_posix(),
+            *(
+                f"hyperbrowser/{path.as_posix()}"
+                for path in ALLOWED_SAFE_KEY_DISPLAY_CALL_FILES
+                if path != Path("mapping_utils.py")
+            ),
+        }
     )
     expected_modules = sorted([*expected_runtime_modules, *EXPECTED_MAPPING_EXTRA_IMPORTERS])
     assert discovered_modules == expected_modules

tests/test_safe_key_display_helper_usage.py

@@ -9,6 +9,7 @@
 HYPERBROWSER_ROOT = Path(__file__).resolve().parents[1] / "hyperbrowser"
 ALLOWED_SAFE_KEY_DISPLAY_CALL_FILES = {
     Path("mapping_utils.py"),
+    Path("client/managers/extension_utils.py"),
     Path("client/managers/list_parsing_utils.py"),
 }