Validate base URL port values during normalization

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/config.py

@@ -60,6 +60,12 @@ def normalize_base_url(base_url: str) -> str:
             )
         if parsed_base_url.username is not None or parsed_base_url.password is not None:
             raise HyperbrowserError("base_url must not include user credentials")
+        try:
+            parsed_base_url.port
+        except ValueError as exc:
+            raise HyperbrowserError(
+                "base_url must contain a valid port number"
+            ) from exc
 
         decoded_base_path = parsed_base_url.path
         for _ in range(10):

tests/test_config.py

@@ -205,6 +205,14 @@ def test_client_config_rejects_empty_or_invalid_base_url():
 
     with pytest.raises(HyperbrowserError, match="include a host"):
         ClientConfig(api_key="test-key", base_url="http://")
+    with pytest.raises(
+        HyperbrowserError, match="base_url must contain a valid port number"
+    ):
+        ClientConfig(api_key="test-key", base_url="https://example.local:99999")
+    with pytest.raises(
+        HyperbrowserError, match="base_url must contain a valid port number"
+    ):
+        ClientConfig(api_key="test-key", base_url="https://example.local:bad")
 
     with pytest.raises(HyperbrowserError, match="must not include query parameters"):
         ClientConfig(api_key="test-key", base_url="https://example.local#frag")
@@ -356,6 +364,14 @@ def test_client_config_normalize_base_url_validates_and_normalizes():
 
     with pytest.raises(HyperbrowserError, match="base_url must start with"):
         ClientConfig.normalize_base_url("example.local")
+    with pytest.raises(
+        HyperbrowserError, match="base_url must contain a valid port number"
+    ):
+        ClientConfig.normalize_base_url("https://example.local:99999")
+    with pytest.raises(
+        HyperbrowserError, match="base_url must contain a valid port number"
+    ):
+        ClientConfig.normalize_base_url("https://example.local:bad")
 
     with pytest.raises(HyperbrowserError, match="must not include query parameters"):
         ClientConfig.normalize_base_url("https://example.local?foo=bar")

tests/test_url_building.py

@@ -98,6 +98,12 @@ def test_client_build_url_rejects_runtime_invalid_base_url_changes():
         ):
             client._build_url("/session")
 
+        client.config.base_url = "https://example.local:99999"
+        with pytest.raises(
+            HyperbrowserError, match="base_url must contain a valid port number"
+        ):
+            client._build_url("/session")
+
         client.config.base_url = "https://example.local/\napi"
         with pytest.raises(
             HyperbrowserError, match="base_url must not contain newline characters"