Treat broken executor errors as non-retryable

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -1,5 +1,6 @@
 import asyncio
 from concurrent.futures import CancelledError as ConcurrentCancelledError
+from concurrent.futures import BrokenExecutor as ConcurrentBrokenExecutor
 import inspect
 import math
 from numbers import Real
@@ -172,6 +173,8 @@ def _is_executor_shutdown_runtime_error(exc: Exception) -> bool:
 
 
 def _is_retryable_exception(exc: Exception) -> bool:
+    if isinstance(exc, ConcurrentBrokenExecutor):
+        return False
     if isinstance(exc, (StopIteration, StopAsyncIteration)):
         return False
     if _is_generator_reentrancy_error(exc):

tests/test_polling.py

@@ -1,5 +1,6 @@
 import asyncio
 from concurrent.futures import CancelledError as ConcurrentCancelledError
+from concurrent.futures import BrokenExecutor as ConcurrentBrokenExecutor
 import math
 from fractions import Fraction
 
@@ -221,6 +222,26 @@ def get_status() -> str:
     assert attempts["count"] == 1
 
 
+def test_poll_until_terminal_status_does_not_retry_broken_executor_errors():
+    attempts = {"count": 0}
+
+    def get_status() -> str:
+        attempts["count"] += 1
+        raise ConcurrentBrokenExecutor("executor is broken")
+
+    with pytest.raises(ConcurrentBrokenExecutor, match="executor is broken"):
+        poll_until_terminal_status(
+            operation_name="sync poll broken-executor passthrough",
+            get_status=get_status,
+            is_terminal_status=lambda value: value == "completed",
+            poll_interval_seconds=0.0001,
+            max_wait_seconds=1.0,
+            max_status_failures=5,
+        )
+
+    assert attempts["count"] == 1
+
+
 def test_poll_until_terminal_status_retries_rate_limit_errors():
     attempts = {"count": 0}
 
@@ -604,6 +625,24 @@ def operation() -> str:
     assert attempts["count"] == 1
 
 
+def test_retry_operation_does_not_retry_broken_executor_errors():
+    attempts = {"count": 0}
+
+    def operation() -> str:
+        attempts["count"] += 1
+        raise ConcurrentBrokenExecutor("executor is broken")
+
+    with pytest.raises(ConcurrentBrokenExecutor, match="executor is broken"):
+        retry_operation(
+            operation_name="sync retry broken-executor passthrough",
+            operation=operation,
+            max_attempts=5,
+            retry_delay_seconds=0.0001,
+        )
+
+    assert attempts["count"] == 1
+
+
 def test_retry_operation_retries_server_errors():
     attempts = {"count": 0}
 
@@ -931,6 +970,29 @@ async def get_status() -> str:
     asyncio.run(run())
 
 
+def test_poll_until_terminal_status_async_does_not_retry_broken_executor_errors():
+    async def run() -> None:
+        attempts = {"count": 0}
+
+        async def get_status() -> str:
+            attempts["count"] += 1
+            raise ConcurrentBrokenExecutor("executor is broken")
+
+        with pytest.raises(ConcurrentBrokenExecutor, match="executor is broken"):
+            await poll_until_terminal_status_async(
+                operation_name="async poll broken-executor passthrough",
+                get_status=get_status,
+                is_terminal_status=lambda value: value == "completed",
+                poll_interval_seconds=0.0001,
+                max_wait_seconds=1.0,
+                max_status_failures=5,
+            )
+
+        assert attempts["count"] == 1
+
+    asyncio.run(run())
+
+
 def test_poll_until_terminal_status_async_retries_server_errors():
     async def run() -> None:
         attempts = {"count": 0}
@@ -1102,6 +1164,27 @@ async def operation() -> str:
     asyncio.run(run())
 
 
+def test_retry_operation_async_does_not_retry_broken_executor_errors():
+    async def run() -> None:
+        attempts = {"count": 0}
+
+        async def operation() -> str:
+            attempts["count"] += 1
+            raise ConcurrentBrokenExecutor("executor is broken")
+
+        with pytest.raises(ConcurrentBrokenExecutor, match="executor is broken"):
+            await retry_operation_async(
+                operation_name="async retry broken-executor passthrough",
+                operation=operation,
+                max_attempts=5,
+                retry_delay_seconds=0.0001,
+            )
+
+        assert attempts["count"] == 1
+
+    asyncio.run(run())
+
+
 def test_retry_operation_async_retries_server_errors():
     async def run() -> None:
         attempts = {"count": 0}
@@ -2174,6 +2257,28 @@ def get_next_page(page: int) -> dict:
     assert attempts["count"] == 1
 
 
+def test_collect_paginated_results_does_not_retry_broken_executor_errors():
+    attempts = {"count": 0}
+
+    def get_next_page(page: int) -> dict:
+        attempts["count"] += 1
+        raise ConcurrentBrokenExecutor("executor is broken")
+
+    with pytest.raises(ConcurrentBrokenExecutor, match="executor is broken"):
+        collect_paginated_results(
+            operation_name="sync paginated broken-executor passthrough",
+            get_next_page=get_next_page,
+            get_current_page_batch=lambda response: response["current"],
+            get_total_page_batches=lambda response: response["total"],
+            on_page_success=lambda response: None,
+            max_wait_seconds=1.0,
+            max_attempts=5,
+            retry_delay_seconds=0.0001,
+        )
+
+    assert attempts["count"] == 1
+
+
 def test_collect_paginated_results_retries_server_errors():
     attempts = {"count": 0}
     collected = []
@@ -2540,6 +2645,31 @@ async def get_next_page(page: int) -> dict:
     asyncio.run(run())
 
 
+def test_collect_paginated_results_async_does_not_retry_broken_executor_errors():
+    async def run() -> None:
+        attempts = {"count": 0}
+
+        async def get_next_page(page: int) -> dict:
+            attempts["count"] += 1
+            raise ConcurrentBrokenExecutor("executor is broken")
+
+        with pytest.raises(ConcurrentBrokenExecutor, match="executor is broken"):
+            await collect_paginated_results_async(
+                operation_name="async paginated broken-executor passthrough",
+                get_next_page=get_next_page,
+                get_current_page_batch=lambda response: response["current"],
+                get_total_page_batches=lambda response: response["total"],
+                on_page_success=lambda response: None,
+                max_wait_seconds=1.0,
+                max_attempts=5,
+                retry_delay_seconds=0.0001,
+            )
+
+        assert attempts["count"] == 1
+
+    asyncio.run(run())
+
+
 def test_collect_paginated_results_async_retries_server_errors():
     async def run() -> None:
         attempts = {"count": 0}