Wrap unreadable extension value lookups

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/extension_utils.py

@@ -55,13 +55,22 @@ def parse_extension_list_response_data(response_data: Any) -> List[ExtensionResp
             "Expected 'extensions' key in response but got "
             f"{_summarize_mapping_keys(response_data)} keys"
         )
-    if not isinstance(response_data["extensions"], list):
+    try:
+        extensions_value = response_data["extensions"]
+    except HyperbrowserError:
+        raise
+    except Exception as exc:
+        raise HyperbrowserError(
+            "Failed to read 'extensions' value from response",
+            original_error=exc,
+        ) from exc
+    if not isinstance(extensions_value, list):
         raise HyperbrowserError(
             "Expected list in 'extensions' key but got "
-            f"{_get_type_name(response_data['extensions'])}"
+            f"{_get_type_name(extensions_value)}"
         )
     parsed_extensions: List[ExtensionResponse] = []
-    for index, extension in enumerate(response_data["extensions"]):
+    for index, extension in enumerate(extensions_value):
         if not isinstance(extension, Mapping):
             raise HyperbrowserError(
                 "Expected extension object at index "

tests/test_extension_utils.py

@@ -169,3 +169,23 @@ def keys(self):
         match="Expected 'extensions' key in response but got \\[<unavailable keys>\\] keys",
     ):
         parse_extension_list_response_data(_BrokenKeysMapping({"id": "ext_1"}))
+
+
+def test_parse_extension_list_response_data_wraps_unreadable_extensions_value():
+    class _BrokenExtensionsLookupMapping(dict):
+        def __contains__(self, key: object) -> bool:
+            return key == "extensions"
+
+        def __getitem__(self, key: object):
+            if key == "extensions":
+                raise RuntimeError("cannot read extensions value")
+            return super().__getitem__(key)
+
+    with pytest.raises(
+        HyperbrowserError, match="Failed to read 'extensions' value from response"
+    ) as exc_info:
+        parse_extension_list_response_data(
+            _BrokenExtensionsLookupMapping({"extensions": []})
+        )
+
+    assert exc_info.value.original_error is not None