Skip to content

Commit c9a8452

Browse files
Tighten open helper constant usage guard
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent 25277f3 commit c9a8452

2 files changed

Lines changed: 16 additions & 4 deletions

File tree

tests/test_file_message_default_constant_import_boundary.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,15 @@
1515
"tests/test_extension_operation_metadata_usage.py",
1616
"tests/test_file_message_default_constant_import_boundary.py",
1717
"tests/test_file_message_default_constant_usage.py",
18+
"tests/test_file_open_error_helper_usage.py",
1819
)
1920

2021
EXPECTED_SESSION_DEFAULT_CONSTANT_CONSUMERS = (
2122
"hyperbrowser/client/managers/session_operation_metadata.py",
2223
"hyperbrowser/client/managers/session_upload_utils.py",
2324
"tests/test_file_message_default_constant_import_boundary.py",
2425
"tests/test_file_message_default_constant_usage.py",
26+
"tests/test_file_open_error_helper_usage.py",
2527
"tests/test_session_operation_metadata.py",
2628
"tests/test_session_upload_metadata_usage.py",
2729
)

tests/test_file_open_error_helper_usage.py

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,25 @@
66

77

88
OPEN_ERROR_HELPER_MODULES = (
9-
"hyperbrowser/client/managers/session_upload_utils.py",
10-
"hyperbrowser/client/managers/sync_manager/extension.py",
11-
"hyperbrowser/client/managers/async_manager/extension.py",
9+
(
10+
"hyperbrowser/client/managers/session_upload_utils.py",
11+
"SESSION_DEFAULT_UPLOAD_OPEN_FILE_ERROR_PREFIX",
12+
),
13+
(
14+
"hyperbrowser/client/managers/sync_manager/extension.py",
15+
"EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX",
16+
),
17+
(
18+
"hyperbrowser/client/managers/async_manager/extension.py",
19+
"EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX",
20+
),
1221
)
1322

1423

1524
def test_file_open_error_messages_use_shared_helper():
16-
for module_path in OPEN_ERROR_HELPER_MODULES:
25+
for module_path, expected_default_constant in OPEN_ERROR_HELPER_MODULES:
1726
module_text = Path(module_path).read_text(encoding="utf-8")
1827
assert "build_open_file_error_message(" in module_text
28+
assert expected_default_constant in module_text
1929
assert "default_prefix=" in module_text
2030
assert "open_error_message=f\"" not in module_text

0 commit comments

Comments
 (0)