Add mapping read-keys import boundary guard

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -172,6 +172,7 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_manager_transport_boundary.py` (manager transport boundary enforcement through shared request helpers),
   - `tests/test_mapping_keys_access_usage.py` (centralized key-iteration boundaries),
   - `tests/test_mapping_read_helper_import_boundary.py` (shared mapping read-helper import boundary enforcement),
+  - `tests/test_mapping_read_keys_helper_import_boundary.py` (shared mapping read-keys helper import boundary enforcement),
   - `tests/test_mapping_reader_usage.py` (shared mapping-read parser usage),
   - `tests/test_mapping_utils_import_boundary.py` (mapping utility import boundary enforcement),
   - `tests/test_model_request_function_parse_boundary.py` (model-request function-level parse boundary enforcement between parsed wrappers and raw helpers),

tests/test_architecture_marker_usage.py

@@ -42,6 +42,7 @@
     "tests/test_manager_helper_import_boundary.py",
     "tests/test_manager_parse_boundary.py",
     "tests/test_manager_transport_boundary.py",
+    "tests/test_mapping_read_keys_helper_import_boundary.py",
     "tests/test_mapping_read_helper_import_boundary.py",
     "tests/test_mapping_reader_usage.py",
     "tests/test_mapping_utils_import_boundary.py",

tests/test_mapping_read_keys_helper_import_boundary.py

@@ -0,0 +1,42 @@
+import ast
+from pathlib import Path
+
+import pytest
+
+from tests.test_tool_mapping_reader_usage import TOOLS_MODULE
+
+pytestmark = pytest.mark.architecture
+
+
+EXPECTED_READ_KEYS_HELPER_EXTRA_IMPORTERS = ("tests/test_mapping_utils.py",)
+
+
+def _imports_read_string_mapping_keys(module_text: str) -> bool:
+    module_ast = ast.parse(module_text)
+    for node in module_ast.body:
+        if not isinstance(node, ast.ImportFrom):
+            continue
+        if node.module != "hyperbrowser.mapping_utils":
+            continue
+        if any(alias.name == "read_string_mapping_keys" for alias in node.names):
+            return True
+    return False
+
+
+def test_read_string_mapping_keys_imports_are_centralized():
+    discovered_modules: list[str] = []
+
+    for module_path in sorted(Path("hyperbrowser").rglob("*.py")):
+        module_text = module_path.read_text(encoding="utf-8")
+        if _imports_read_string_mapping_keys(module_text):
+            discovered_modules.append(module_path.as_posix())
+
+    for module_path in sorted(Path("tests").glob("test_*.py")):
+        module_text = module_path.read_text(encoding="utf-8")
+        if _imports_read_string_mapping_keys(module_text):
+            discovered_modules.append(module_path.as_posix())
+
+    expected_modules = sorted(
+        [TOOLS_MODULE.as_posix(), *EXPECTED_READ_KEYS_HELPER_EXTRA_IMPORTERS]
+    )
+    assert discovered_modules == expected_modules