Require concrete operation-name inputs in polling validators

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -116,7 +116,7 @@ def _normalize_non_negative_real(value: float, *, field_name: str) -> float:
 
 
 def _validate_operation_name(operation_name: str) -> None:
-    if not isinstance(operation_name, str):
+    if type(operation_name) is not str:
         raise HyperbrowserError("operation_name must be a string")
     try:
         normalized_operation_name = operation_name.strip()

tests/test_polling.py

@@ -7316,116 +7316,9 @@ async def _operation() -> str:
     "runner",
     [_run_retry_operation_sync_with_name, _run_retry_operation_async_with_name],
 )
-def test_retry_operation_wraps_operation_name_strip_runtime_errors(runner):
+def test_retry_operation_rejects_string_subclass_operation_names(runner):
     class _BrokenOperationName(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise RuntimeError("operation_name strip exploded")
-
-    with pytest.raises(
-        HyperbrowserError, match="Failed to normalize operation_name"
-    ) as exc_info:
-        runner(_BrokenOperationName("poll operation"))
-
-    assert isinstance(exc_info.value.original_error, RuntimeError)
-
-
-@pytest.mark.parametrize(
-    "runner",
-    [_run_retry_operation_sync_with_name, _run_retry_operation_async_with_name],
-)
-def test_retry_operation_preserves_operation_name_strip_hyperbrowser_errors(runner):
-    class _BrokenOperationName(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise HyperbrowserError("custom operation_name strip failure")
-
-    with pytest.raises(
-        HyperbrowserError, match="custom operation_name strip failure"
-    ) as exc_info:
-        runner(_BrokenOperationName("poll operation"))
-
-    assert exc_info.value.original_error is None
-
-
-@pytest.mark.parametrize(
-    "runner",
-    [_run_retry_operation_sync_with_name, _run_retry_operation_async_with_name],
-)
-def test_retry_operation_wraps_non_string_operation_name_strip_results(runner):
-    class _BrokenOperationName(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            return object()
-
-    with pytest.raises(
-        HyperbrowserError, match="Failed to normalize operation_name"
-    ) as exc_info:
-        runner(_BrokenOperationName("poll operation"))
-
-    assert isinstance(exc_info.value.original_error, TypeError)
-
-
-@pytest.mark.parametrize(
-    "runner",
-    [_run_retry_operation_sync_with_name, _run_retry_operation_async_with_name],
-)
-def test_retry_operation_wraps_operation_name_length_runtime_errors(runner):
-    class _BrokenOperationName(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            return "poll operation"
-
-        def __len__(self):
-            raise RuntimeError("operation_name length exploded")
-
-    with pytest.raises(
-        HyperbrowserError, match="Failed to validate operation_name length"
-    ) as exc_info:
-        runner(_BrokenOperationName("poll operation"))
-
-    assert isinstance(exc_info.value.original_error, RuntimeError)
-
-
-@pytest.mark.parametrize(
-    "runner",
-    [_run_retry_operation_sync_with_name, _run_retry_operation_async_with_name],
-)
-def test_retry_operation_wraps_operation_name_character_validation_failures(runner):
-    class _BrokenOperationName(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            return "poll operation"
-
-        def __iter__(self):
-            raise RuntimeError("operation_name iteration exploded")
-
-    with pytest.raises(
-        HyperbrowserError, match="Failed to validate operation_name characters"
-    ) as exc_info:
-        runner(_BrokenOperationName("poll operation"))
-
-    assert isinstance(exc_info.value.original_error, RuntimeError)
-
-
-@pytest.mark.parametrize(
-    "runner",
-    [_run_retry_operation_sync_with_name, _run_retry_operation_async_with_name],
-)
-def test_retry_operation_preserves_operation_name_character_validation_hyperbrowser_errors(
-    runner,
-):
-    class _BrokenOperationName(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            return "poll operation"
-
-        def __iter__(self):
-            raise HyperbrowserError("custom operation_name character failure")
+        pass
 
-    with pytest.raises(
-        HyperbrowserError, match="custom operation_name character failure"
-    ) as exc_info:
+    with pytest.raises(HyperbrowserError, match="operation_name must be a string"):
         runner(_BrokenOperationName("poll operation"))
-
-    assert exc_info.value.original_error is None