Tighten request method/url strip output typing

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/error_utils.py

@@ -80,7 +80,7 @@ def _has_non_blank_text(value: Any) -> bool:
         return False
     try:
         stripped_value = value.strip()
-        if not isinstance(stripped_value, str):
+        if type(stripped_value) is not str:
             return False
         return bool(stripped_value)
     except Exception:
@@ -107,13 +107,13 @@ def _normalize_request_method(method: Any) -> str:
         if not isinstance(raw_method, str):
             return "UNKNOWN"
         stripped_method = raw_method.strip()
-        if not isinstance(stripped_method, str) or not stripped_method:
+        if type(stripped_method) is not str or not stripped_method:
             return "UNKNOWN"
         normalized_method = stripped_method.upper()
-        if not isinstance(normalized_method, str):
+        if type(normalized_method) is not str:
             return "UNKNOWN"
         lowered_method = normalized_method.lower()
-        if not isinstance(lowered_method, str):
+        if type(lowered_method) is not str:
             return "UNKNOWN"
     except Exception:
         return "UNKNOWN"
@@ -151,10 +151,10 @@ def _normalize_request_url(url: Any) -> str:
 
     try:
         normalized_url = raw_url.strip()
-        if not isinstance(normalized_url, str) or not normalized_url:
+        if type(normalized_url) is not str or not normalized_url:
             return "unknown URL"
         lowered_url = normalized_url.lower()
-        if not isinstance(lowered_url, str):
+        if type(lowered_url) is not str:
             return "unknown URL"
     except Exception:
         return "unknown URL"

tests/test_transport_error_utils.py

@@ -250,6 +250,15 @@ def __len__(self):
         raise RuntimeError("method length exploded")
 
 
+class _StringSubclassMethodStripResult(str):
+    class _StripResult(str):
+        pass
+
+    def strip(self, chars=None):  # type: ignore[override]
+        _ = chars
+        return self._StripResult("get")
+
+
 class _BrokenStripUrl(str):
     def strip(self, chars=None):  # type: ignore[override]
         _ = chars
@@ -277,6 +286,15 @@ def __iter__(self):
         raise RuntimeError("url iteration exploded")
 
 
+class _StringSubclassUrlStripResult(str):
+    class _StripResult(str):
+        pass
+
+    def strip(self, chars=None):  # type: ignore[override]
+        _ = chars
+        return self._StripResult("https://example.com/path")
+
+
 class _StringifiesToBrokenSubclass:
     class _BrokenString(str):
         def __iter__(self):
@@ -771,6 +789,15 @@ def test_format_generic_request_failure_message_normalizes_method_length_failure
     assert message == "Request UNKNOWN https://example.com/path failed"
 
 
+def test_format_generic_request_failure_message_normalizes_method_strip_string_subclass_results():
+    message = format_generic_request_failure_message(
+        method=_StringSubclassMethodStripResult("get"),
+        url="https://example.com/path",
+    )
+
+    assert message == "Request UNKNOWN https://example.com/path failed"
+
+
 def test_format_generic_request_failure_message_normalizes_url_strip_failures():
     message = format_generic_request_failure_message(
         method="GET",
@@ -798,6 +825,15 @@ def test_format_generic_request_failure_message_normalizes_url_iteration_failure
     assert message == "Request GET unknown URL failed"
 
 
+def test_format_generic_request_failure_message_normalizes_url_strip_string_subclass_results():
+    message = format_generic_request_failure_message(
+        method="GET",
+        url=_StringSubclassUrlStripResult("https://example.com/path"),
+    )
+
+    assert message == "Request GET unknown URL failed"
+
+
 def test_format_request_failure_message_truncates_very_long_fallback_urls():
     very_long_url = "https://example.com/" + ("a" * 1200)
     message = format_request_failure_message(