Add mapping helper usage centralization guard

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -171,6 +171,7 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_manager_parse_boundary.py` (manager response-parse boundary enforcement through shared helper modules),
   - `tests/test_manager_transport_boundary.py` (manager transport boundary enforcement through shared request helpers),
   - `tests/test_mapping_copy_helper_import_boundary.py` (shared mapping copy-helper import boundary enforcement),
+  - `tests/test_mapping_helpers_usage.py` (shared mapping read/copy helper usage centralization),
   - `tests/test_mapping_keys_access_usage.py` (centralized key-iteration boundaries),
   - `tests/test_mapping_read_helper_import_boundary.py` (shared mapping read-helper import boundary enforcement),
   - `tests/test_mapping_read_keys_helper_import_boundary.py` (shared mapping read-keys helper import boundary enforcement),

tests/test_architecture_marker_usage.py

@@ -43,6 +43,7 @@
     "tests/test_manager_parse_boundary.py",
     "tests/test_manager_transport_boundary.py",
     "tests/test_mapping_copy_helper_import_boundary.py",
+    "tests/test_mapping_helpers_usage.py",
     "tests/test_mapping_read_keys_helper_import_boundary.py",
     "tests/test_mapping_read_helper_import_boundary.py",
     "tests/test_mapping_reader_usage.py",

tests/test_mapping_helpers_usage.py

@@ -0,0 +1,55 @@
+from pathlib import Path
+
+import pytest
+
+from tests.guardrail_ast_utils import collect_name_call_lines, read_module_ast
+
+pytestmark = pytest.mark.architecture
+
+HYPERBROWSER_ROOT = Path(__file__).resolve().parents[1] / "hyperbrowser"
+ALLOWED_READ_KEYS_CALL_FILES = {
+    Path("mapping_utils.py"),
+    Path("tools/__init__.py"),
+}
+ALLOWED_COPY_VALUES_CALL_FILES = {
+    Path("mapping_utils.py"),
+    Path("tools/__init__.py"),
+}
+
+
+def _python_files() -> list[Path]:
+    return sorted(HYPERBROWSER_ROOT.rglob("*.py"))
+
+
+def test_read_string_mapping_keys_usage_is_centralized():
+    violations: list[str] = []
+
+    for path in _python_files():
+        relative_path = path.relative_to(HYPERBROWSER_ROOT)
+        module = read_module_ast(path)
+        helper_calls = collect_name_call_lines(module, "read_string_mapping_keys")
+        if not helper_calls:
+            continue
+        if relative_path in ALLOWED_READ_KEYS_CALL_FILES:
+            continue
+        for line in helper_calls:
+            violations.append(f"{relative_path}:{line}")
+
+    assert violations == []
+
+
+def test_copy_mapping_values_by_string_keys_usage_is_centralized():
+    violations: list[str] = []
+
+    for path in _python_files():
+        relative_path = path.relative_to(HYPERBROWSER_ROOT)
+        module = read_module_ast(path)
+        helper_calls = collect_name_call_lines(module, "copy_mapping_values_by_string_keys")
+        if not helper_calls:
+            continue
+        if relative_path in ALLOWED_COPY_VALUES_CALL_FILES:
+            continue
+        for line in helper_calls:
+            violations.append(f"{relative_path}:{line}")
+
+    assert violations == []