Skip to content

Update SplineMPE tests #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tianluyuan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update SplineMPE tests #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9678f0
update splinempe tests
tianluyuan Nov 13, 2025
a50a6f2
try a new reference for one of the tests
tianluyuan Nov 13, 2025
a99528b
remove special handling for splinempe / timer
ric-evans Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,31 +532,6 @@ jobs:
cat $outfile
pip install . # don't need icecube, so no docker container needed


# --------------------------------------------------------------------
# splinempe: special handling + gh-issue reminder timer
if [[ "${{ matrix.reco_algo }}" == "splinempe" ]]; then
python tests/compare_scan_results.py \
--actual $outfile \
--expected tests/data/results_json/${{ matrix.reco_algo }}/$(basename $outfile) \
--assert \
--compare-different-versions-ok \
|| (cat $(ls *.diff.json) && false)

# put the timer after, so at least we know if the test passes
start_time="2025-11-7" # Set the starting date
end_time=$(date -d "$start_time +2 months" +%s)
current_time=$(date +%s)
if (( current_time >= end_time )); then
echo "::error::alarm went off, how's https://github.com/icecube/skymap_scanner/issues/242 going? Are version-0 result files still being used for splinempe?"
exit 1
fi

exit 0
fi
# --------------------------------------------------------------------


python tests/compare_scan_results.py \
--actual $outfile \
--expected tests/data/results_json/${{ matrix.reco_algo }}/$(basename $outfile) \
Expand Down
1 change: 0 additions & 1 deletion resources/utils/comp_new_jsons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"--expected",
files["expected"],
"--assert",
"--compare-different-versions-ok",
]
print(f"\n\nRunning: {' '.join(command)}")
subprocess.check_call(command)
124 changes: 89 additions & 35 deletions tests/data/results_json/splinempe/run00136662.evt000035405932.neutrino_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,89 +4,143 @@
"index",
"llh",
"E_in",
"E_tot"
"E_tot",
"X",
"Y",
"Z",
"T"
],
"data": [
[
0,
1046.7078636968658,
NaN,
NaN
1048.1587421297838,
"<skyreader.nan>",
"<skyreader.nan>",
-159.47995701532338,
210.04288726880264,
23.86742310798023,
31923.29600153164
],
[
1,
1079.0788843076734,
NaN,
NaN
1079.078884227916,
"<skyreader.nan>",
"<skyreader.nan>",
-245.17802824420616,
141.50070716694125,
221.33241097186726,
32393.17719225609
],
[
2,
1127.4074434034721,
NaN,
NaN
1134.9910299573835,
"<skyreader.nan>",
"<skyreader.nan>",
334.7432424069043,
322.5510878653598,
460.55733233257956,
32691.023411225193
],
[
3,
1089.8543019687863,
NaN,
NaN
1089.8543176865783,
"<skyreader.nan>",
"<skyreader.nan>",
-152.60541235319727,
95.05712661988036,
153.04050425530494,
32706.139915879474
],
[
4,
1049.9445198407468,
NaN,
NaN
1049.944539655825,
"<skyreader.nan>",
"<skyreader.nan>",
-214.9727664985283,
239.7046974425789,
197.28588857041296,
32591.08553768096
],
[
5,
1068.6341879665208,
NaN,
NaN
"<skyreader.nan>",
"<skyreader.nan>",
-476.0892747851045,
313.60660153405433,
308.8448087465392,
32804.473565632885
],
[
6,
1110.6678888455301,
NaN,
NaN
"<skyreader.nan>",
"<skyreader.nan>",
38.54781958166542,
521.1396182765375,
201.97156283332467,
31640.05037767647
],
[
7,
1227.878811273679,
NaN,
NaN
1125.2372784404552,
"<skyreader.nan>",
"<skyreader.nan>",
-87.83000472704332,
153.7822987367307,
377.6461807071271,
33581.86792460527
],
[
8,
1044.1316310736643,
NaN,
NaN
1044.13164548172,
"<skyreader.nan>",
"<skyreader.nan>",
-143.2051439116106,
236.1881757066859,
311.89903754427485,
31866.43476977145
],
[
9,
1184.532089552924,
NaN,
NaN
"<skyreader.nan>",
"<skyreader.nan>",
-224.64617456930296,
419.92624610407165,
-216.94044061994714,
32214.34422288417
],
[
10,
1121.4424378701983,
NaN,
NaN
"<skyreader.nan>",
"<skyreader.nan>",
422.5625871113881,
529.8847537128725,
-195.12432936498135,
33009.955400588595
],
[
11,
1089.6827496407657,
NaN,
NaN
1113.4950899300022,
"<skyreader.nan>",
"<skyreader.nan>",
-2.5228324073985666,
63.02411919540087,
136.8574651377062,
32527.600177820048
]
],
"metadata": {
"nside": 1,
"complete": true,
"run_id": 136662,
"event_id": 35405932,
"event_type": "neutrino",
"mjd": 59723.32051140454,
"is_real_event": true
"is_real_event": true,
"version": 1
}
}
}
}
Loading
Loading