refactor(AG-M1-T3): rename isInterProject params to interProject in private methods

Eliminates shadowing of the imported isInterProject function in
json-report-generator and markdown-report-generator private methods.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: aledlie

sidequest/pipeline-core/reports/json-report-generator.ts

@@ -274,12 +274,12 @@ export class JSONReportGenerator {
    * Generate metadata section
    * @private
    */
-  private static _generateMetadata(scanResult: ScanResult, isInterProject: boolean): Record<string, unknown> {
+  private static _generateMetadata(scanResult: ScanResult, interProject: boolean): Record<string, unknown> {
     const metadata = scanResult.scan_metadata ?? {};
     const repoInfo = scanResult.repository_info ?? {};
 
     return {
-      ...(isInterProject ? {
+      ...(interProject ? {
         repository_count: metadata.repository_count ?? 0,
         repositories: (scanResult.scanned_repositories ?? []).map(r => r.name)
       } : {
@@ -298,12 +298,12 @@ export class JSONReportGenerator {
    * Generate summary section
    * @private
    */
-  private static _generateSummary(scanResult: ScanResult, isInterProject: boolean): ReportSummary {
+  private static _generateSummary(scanResult: ScanResult, interProject: boolean): ReportSummary {
     const metrics = scanResult.metrics ?? {};
-    const duplicateGroups = isInterProject
+    const duplicateGroups = interProject
       ? (scanResult.cross_repository_duplicates ?? [])
       : (scanResult.duplicate_groups ?? []);
-    const suggestions = isInterProject
+    const suggestions = interProject
       ? (scanResult.cross_repository_suggestions ?? [])
       : (scanResult.suggestions ?? []);
 
@@ -314,7 +314,7 @@ export class JSONReportGenerator {
       complexity_distribution: this._calculateComplexityDistribution(suggestions)
     };
 
-    if (isInterProject) {
+    if (interProject) {
       summary.repositories_scanned = metrics.total_repositories_scanned ?? 0;
       summary.cross_repo_duplicates = duplicateGroups.length;
       summary.top_impact_score = duplicateGroups.length > 0
@@ -348,11 +348,11 @@ export class JSONReportGenerator {
    */
   private static _formatDuplicateGroups(
     scanResult: ScanResult,
-    isInterProject: boolean,
+    interProject: boolean,
     maxGroups: number | null,
     includeSourceCode: boolean
   ): Record<string, unknown>[] {
-    const groups = isInterProject
+    const groups = interProject
       ? (scanResult.cross_repository_duplicates ?? [])
       : (scanResult.duplicate_groups ?? []);
 
@@ -370,7 +370,7 @@ export class JSONReportGenerator {
         similarity_method: group.similarity_method,
         member_block_ids: group.member_block_ids ?? [],
         affected_files: group.affected_files ?? [],
-        ...(isInterProject ? {
+        ...(interProject ? {
           repository_count: group.repository_count,
           affected_repositories: group.affected_repositories ?? []
         } : {}),
@@ -392,10 +392,10 @@ export class JSONReportGenerator {
    */
   private static _formatSuggestions(
     scanResult: ScanResult,
-    isInterProject: boolean,
+    interProject: boolean,
     maxSuggestions: number | null
   ): Record<string, unknown>[] {
-    const suggestions = isInterProject
+    const suggestions = interProject
       ? (scanResult.cross_repository_suggestions ?? [])
       : (scanResult.suggestions ?? []);
 
@@ -414,7 +414,7 @@ export class JSONReportGenerator {
         breaking_changes: suggestion.breaking_changes ?? false,
         confidence: suggestion.confidence,
         strategy_rationale: suggestion.strategy_rationale,
-        ...(isInterProject ? {
+        ...(interProject ? {
           affected_repositories: suggestion.affected_repositories ?? [],
           affected_repositories_count: suggestion.affected_repositories_count ?? 0
         } : {

sidequest/pipeline-core/reports/markdown-report-generator.ts

@@ -107,14 +107,14 @@ export class MarkdownReportGenerator {
    * Generate report header
    * @private
    */
-  private static _generateHeader(scanResult: ScanResult, isInterProject: boolean): string {
+  private static _generateHeader(scanResult: ScanResult, interProject: boolean): string {
     const metadata = scanResult.scan_metadata ?? {};
     const repoInfo = scanResult.repository_info ?? {};
-    const scanType = isInterProject ? 'Inter-Project' : 'Intra-Project';
+    const scanType = interProject ? 'Inter-Project' : 'Intra-Project';
 
     let header = `# ${scanType} Duplicate Detection Report\n\n`;
 
-    if (isInterProject) {
+    if (interProject) {
       header += `**Repositories:** ${metadata.repository_count ?? 0}\n`;
     } else {
       header += `**Repository:** ${repoInfo.name ?? 'Unknown'}\n`;
@@ -131,12 +131,12 @@ export class MarkdownReportGenerator {
    * Generate metrics table
    * @private
    */
-  private static _generateMetrics(scanResult: ScanResult, isInterProject: boolean): string {
+  private static _generateMetrics(scanResult: ScanResult, interProject: boolean): string {
     const metrics = scanResult.metrics ?? {};
 
     let markdown = '## Metrics\n\n';
 
-    if (isInterProject) {
+    if (interProject) {
       markdown += '| Metric | Value |\n';
       markdown += '|--------|-------|\n';
       markdown += `| Repositories Scanned | ${metrics.total_repositories_scanned ?? 0} |\n`;
@@ -191,15 +191,15 @@ export class MarkdownReportGenerator {
    */
   private static _generateDuplicateGroups(
     scanResult: ScanResult,
-    isInterProject: boolean,
+    interProject: boolean,
     maxGroups: number,
     includeDetails: boolean
   ): string {
-    const groups = isInterProject
+    const groups = interProject
       ? (scanResult.cross_repository_duplicates ?? [])
       : (scanResult.duplicate_groups ?? []);
 
-    let markdown = isInterProject
+    let markdown = interProject
       ? '## Top Cross-Repository Duplicates\n\n'
       : '## Top Duplicate Groups\n\n';
 
@@ -220,7 +220,7 @@ export class MarkdownReportGenerator {
       markdown += `- **Language:** ${group.language}\n`;
       markdown += `- **Occurrences:** ${group.occurrence_count}\n`;
 
-      if (isInterProject) {
+      if (interProject) {
         markdown += `- **Repositories:** ${group.repository_count ?? 0} (${group.affected_repositories?.join(', ') ?? 'N/A'})\n`;
       }
 
@@ -252,15 +252,15 @@ export class MarkdownReportGenerator {
    */
   private static _generateSuggestions(
     scanResult: ScanResult,
-    isInterProject: boolean,
+    interProject: boolean,
     maxSuggestions: number,
     includeDetails: boolean
   ): string {
-    const suggestions = isInterProject
+    const suggestions = interProject
       ? (scanResult.cross_repository_suggestions ?? [])
       : (scanResult.suggestions ?? []);
 
-    let markdown = isInterProject
+    let markdown = interProject
       ? '## Top Cross-Repository Suggestions\n\n'
       : '## Top Consolidation Suggestions\n\n';
 
@@ -283,7 +283,7 @@ export class MarkdownReportGenerator {
       markdown += `- **Complexity:** ${this._formatComplexity(suggestion.complexity)}\n`;
       markdown += `- **Risk:** ${this._formatRisk(suggestion.migration_risk)}\n`;
 
-      if (isInterProject) {
+      if (interProject) {
         const repos = suggestion.affected_repositories ?? [];
         markdown += `- **Repositories:** ${repos.join(', ')}\n`;
       } else {