Invalid `This qualifier is redundant` when a variable is shadowed by a property with the same name and compatible signature

[MangelMaxime]

Version

Ionide 7.18.2

Dotnet Info

.NET SDK:
Version: 8.0.100
Commit: 57efcf1350
Workload version: 8.0.100-manifests.6c33ef20

Runtime Environment:
OS Name: Mac OS X
OS Version: 14.4
OS Platform: Darwin
RID: osx-arm64
Base Path: /usr/local/share/dotnet/sdk/8.0.100/

.NET workloads installed:
Workload version: 8.0.100-manifests.6c33ef20
There are no installed workloads to display.

Host:
Version: 8.0.0
Architecture: arm64
Commit: 5535e31a71

.NET SDKs installed:
6.0.416 [/usr/local/share/dotnet/sdk]
7.0.403 [/usr/local/share/dotnet/sdk]
8.0.100-rc.2.23502.2 [/usr/local/share/dotnet/sdk]
8.0.100 [/usr/local/share/dotnet/sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.24 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 7.0.13 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.0-rc.2.23480.2 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.0 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.24 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 7.0.13 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.0-rc.2.23479.6 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.0 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
None

Environment variables:
Not set

global.json file:
/Users/mmangel/Workspaces/Github/glutinum-org/Glutinum.Converter/global.json

Learn more:
https://aka.ms/dotnet/info

Download .NET:
https://aka.ms/dotnet/download

Steps to reproduce

Load this code and see that envelop.user.Name has a redundant quick fix associated to it.

type User (name) =
    member val Name = name

type Envelop () =
    member val user = User("toto")

let test =
    let user = User("user")
    let envelop = Envelop()

    if envelop.user.Name = "maxime" then
        printfn "It works"
    else
        printfn "It doesn't work"

Details

Should not be reported as redundant

Logs

No response

Checklist

• I have looked through existing issues to make sure that this bug has not been reported before
• I have provided a descriptive title for this issue
• I have made sure that that this bug is reproducible on the latest version of the package
• I have provided all the information needed to reproduce this bug as efficiently as possible
• I or my company would be willing to contribute this fix
  • Yes but don't have the time right now, as I am trying to close up a release for Glutinum

[github-actions]

🤖 This is an automated response from Repo Assist.

The root cause of this false positive lies upstream in FCS (the F# Compiler Service), not in FSAC's code fix itself.

FSAC's RemoveRedundantQualifier.fs simply activates whenever FCS emits a diagnostic with the message "This qualifier is redundant". In the scenario you describe, FCS incorrectly fires that diagnostic on envelop.user.Name because the local variable user shadows the Envelop.user property — even though envelop.user is unambiguous.

Recommended action: file or track this in dotnet/fsharp as a false-positive in the SimplifyNameAnalyzer / redundant-qualifier warning. Once FCS stops emitting the diagnostic incorrectly, FSAC's code fix will automatically stop offering it.

In the meantime, the workaround is to set FSharp.SimplifyNameAnalyzer to false in your editor settings (default is false already, per the README).

Generated by Repo Assist

To install this workflow, run gh aw add githubnext/agentics/workflows/repo-assist.md@0d6e8cf9db90470cd5477c6a40b350fd9f9e1422. View source at https://github.com/githubnext/agentics/tree/0d6e8cf9db90470cd5477c6a40b350fd9f9e1422/workflows/repo-assist.md.

[Krzysztof-Cieslak]

/repo-assist create PR with tests for this scenario to check if it's still happening

[github-actions]

Pull request created: #1482

Generated by Repo Assist

[github-actions]

🤖 This is an automated response from Repo Assist.

A new draft PR has been created with a regression test for this scenario. The test uses checkNotApplicable to verify that the "Remove redundant qualifier" code fix is not offered when envelop.user.Name is used and a local variable user shadows the Envelop.user property.

If the test passes, it confirms the false positive is no longer occurring. If it fails, it will serve as a CI signal that the upstream FCS issue is still present.

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@7ee2b60744abf71b985bead4599640f165edcd93