fixup! feat: Add Cisco IOS-XR Provider and implement interface stubs

Author: sven-rosenzweig

internal/provider/cisco/iosxr/provider.go

@@ -42,9 +42,9 @@ func (p *Provider) Disconnect(ctx context.Context, conn *deviceutil.Connection)
 	return p.conn.Close()
 }
 
-func (p *Provider) EnsureInterface(ctx context.Context, req *provider.InterfaceRequest) (provider.Result, error) {
+func (p *Provider) EnsureInterface(ctx context.Context, req *provider.InterfaceRequest) error {
 	if p.client == nil {
-		return provider.Result{}, fmt.Errorf("client is not connected")
+		return fmt.Errorf("client is not connected")
 	}
 	var name string = req.Interface.Spec.Name
 
@@ -56,7 +56,7 @@ func (p *Provider) EnsureInterface(ctx context.Context, req *provider.InterfaceR
 	physif.Statistics.LoadInterval = 30
 	owner, err := ExractMTUOwnerFromIfaceName(name)
 	if err != nil {
-		return provider.Result{}, fmt.Errorf("failed to extract MTU owner from interface name %s: %w", name, err)
+		return fmt.Errorf("failed to extract MTU owner from interface name %s: %w", name, err)
 	}
 	physif.MTUs = MTUs{MTU: []MTU{{MTU: uint16(req.Interface.Spec.MTU), Owner: string(owner)}}}
 
@@ -67,18 +67,18 @@ func (p *Provider) EnsureInterface(ctx context.Context, req *provider.InterfaceR
 	physif.Statistics.LoadInterval = uint8(30)
 
 	if len(req.Interface.Spec.IPv4Addresses) == 0 {
-		return provider.Result{}, fmt.Errorf("no IPv4 address configured for interface %s", name)
+		return fmt.Errorf("no IPv4 address configured for interface %s", name)
 	}
 
 	if len(req.Interface.Spec.IPv4Addresses) > 1 {
-		return provider.Result{}, fmt.Errorf("only a single primary IPv4 address is supported for interface %s", name)
+		return fmt.Errorf("only a single primary IPv4 address is supported for interface %s", name)
 	}
 
 	// (fixme): support IPv6 addresses, IPv6 neighbor config
 
 	ip, ipNet, err := net.ParseCIDR(req.Interface.Spec.IPv4Addresses[0])
 	if err != nil {
-		return provider.Result{}, fmt.Errorf("failed to parse IPv4 address %s: %w", req.Interface.Spec.IPv4Addresses[0], err)
+		return fmt.Errorf("failed to parse IPv4 address %s: %w", req.Interface.Spec.IPv4Addresses[0], err)
 	}
 
 	physif.IPv4Network = IPv4Network{
@@ -97,18 +97,18 @@ func (p *Provider) EnsureInterface(ctx context.Context, req *provider.InterfaceR
 		// Interface does not exist, create it
 		err = p.client.Update(ctx, physif)
 		if err != nil {
-			return provider.Result{}, fmt.Errorf("failed to create interface %s: %w", req.Interface.Spec.Name, err)
+			return fmt.Errorf("failed to create interface %s: %w", req.Interface.Spec.Name, err)
 		}
 		fmt.Printf("Interface %s created successfully\n", req.Interface.Spec.Name)
-		return provider.Result{}, nil
+		return nil
 	}
 
 	err = p.client.Patch(ctx, physif)
 	if err != nil {
-		return provider.Result{}, err
+		return err
 	}
 
-	return provider.Result{}, nil
+	return nil
 }
 
 func (p *Provider) DeleteInterface(ctx context.Context, req *provider.InterfaceRequest) error {