wip: portchannelconfig

Author: nikatza

PROJECT

@@ -195,4 +195,13 @@ resources:
   group: nx
   kind: VPCDomain
   path: github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1
+- api:
+    crdVersion: v1
+    namespaced: true
+  domain: cisco.networking.metal.ironcore.dev
+  group: nx
+  kind: PortChannelConfig
+  controller: false
+  path: github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1
+  version: v1alpha1
 version: "3"

Tiltfile

@@ -52,6 +52,7 @@ k8s_resource(new_name='eth1-10', objects=['eth1-10:interface'], trigger_mode=TRI
 k8s_resource(new_name='eth1-30', objects=['eth1-30:interface'], trigger_mode=TRIGGER_MODE_MANUAL, auto_init=False)
 k8s_resource(new_name='eth1-31', objects=['eth1-31:interface'], trigger_mode=TRIGGER_MODE_MANUAL, auto_init=False)
 k8s_resource(new_name='eth1-32', objects=['eth1-32:interface'], trigger_mode=TRIGGER_MODE_MANUAL, auto_init=False)
+k8s_resource(new_name='po1-cfg', objects=['po1-cfg:portchannelconfig'], trigger_mode=TRIGGER_MODE_MANUAL, auto_init=False)
 k8s_resource(new_name='po1', objects=['po1:interface'],  trigger_mode=TRIGGER_MODE_MANUAL, auto_init=False)
 k8s_resource(new_name='po2', objects=['po2:interface'],  trigger_mode=TRIGGER_MODE_MANUAL, auto_init=False)
 

api/cisco/nx/v1alpha1/portchannelconfig_types.go

@@ -0,0 +1,52 @@
+// SPDX-FileCopyrightText: 2025 SAP SE or an SAP affiliate company and IronCore contributors
+// SPDX-License-Identifier: Apache-2.0
+
+package v1alpha1
+
+import (
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+	v1alpha1 "github.com/ironcore-dev/network-operator/api/core/v1alpha1"
+)
+
+// +kubebuilder:rbac:groups=nx.cisco.networking.metal.ironcore.dev,resources=portchannelconfigs,verbs=get;list;watch
+
+// PortChannelConfig defines the desired state of a PortChannel.
+// Use as provider specific resource for core resources of type `Interface` (sub-type `Aggregate`).
+type PortChannelConfigSpec struct {
+	// VPCPeerLink indicates whether this PortChannel is part of the vPC peer link.
+	// +optional
+	// +kubebuilder:default=false
+	VPCPeerLink bool `json:"vpcPeerLink,omitempty"`
+}
+
+// +kubebuilder:object:root=true
+// +kubebuilder:resource:path=portchannelconfigs
+// +kubebuilder:resource:singular=portchannelconfig
+// +kubebuilder:resource:shortName=pccfg
+
+// PortChannelConfig is the Schema for the NVE API
+type PortChannelConfig struct {
+	metav1.TypeMeta   `json:",inline"`
+	metav1.ObjectMeta `json:"metadata,omitempty,omitzero"`
+
+	// spec defines the desired state of NVE
+	// +required
+	Spec PortChannelConfigSpec `json:"spec"`
+}
+
+// +kubebuilder:object:root=true
+
+// NVEList contains a list of NVE
+type PortChannelConfigList struct {
+	metav1.TypeMeta `json:",inline"`
+	metav1.ListMeta `json:"metadata,omitempty"`
+	Items           []PortChannelConfig `json:"items"`
+}
+
+// init registers the PortChannelConfig type with the core v1alpha1 scheme and sets
+// itself as a dependency for the NVE core type.
+func init() {
+	v1alpha1.RegisterInterfaceDependency(v1alpha1.InterfaceTypeAggregate, GroupVersion.WithKind("PortChannelConfig"))
+	SchemeBuilder.Register(&PortChannelConfig{}, &PortChannelConfigList{})
+}

api/cisco/nx/v1alpha1/zz_generated.deepcopy.go

@@ -109,6 +109,12 @@ const (
 
 	// WaitingForDependenciesReason indicates that the resource is waiting for its dependencies to be ready.
 	WaitingForDependenciesReason = "WaitingForDependencies"
+
+	// IncompatibleProviderConfigRef indicates that the referenced provider configuration is not compatible with the target platform.
+	IncompatibleProviderConfigRef = "IncompatibleProviderConfigRef"
+
+	// ProviderConfigFoundReason indicates that the referenced provider configuration is already assigned.
+	ProviderConfigFoundReason = "ProviderConfigFound"
 )
 
 // Reasons that are specific to [Interface] objects.

api/core/v1alpha1/groupversion_info.go

@@ -4,7 +4,10 @@
 package v1alpha1
 
 import (
+	"sync"
+
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime/schema"
 )
 
 // InterfaceSpec defines the desired state of Interface.
@@ -311,6 +314,18 @@ type InterfaceList struct {
 	Items           []Interface `json:"items"`
 }
 
+var (
+	InterfaceDependencies   = make(map[InterfaceType][]schema.GroupVersionKind)
+	interfaceDependenciesMu sync.Mutex
+)
+
+// RegisterInterfaceDependency adds GVKs to the interface dependency registry.
+func RegisterInterfaceDependency(t InterfaceType, gvk schema.GroupVersionKind) {
+	interfaceDependenciesMu.Lock()
+	defer interfaceDependenciesMu.Unlock()
+	InterfaceDependencies[t] = append(InterfaceDependencies[t], gvk)
+}
+
 func init() {
 	SchemeBuilder.Register(&Interface{}, &InterfaceList{})
 }

api/core/v1alpha1/interface_types.go

@@ -0,0 +1,54 @@
+---
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+  annotations:
+    controller-gen.kubebuilder.io/version: v0.19.0
+  name: portchannelconfigs.nx.cisco.networking.metal.ironcore.dev
+spec:
+  group: nx.cisco.networking.metal.ironcore.dev
+  names:
+    kind: PortChannelConfig
+    listKind: PortChannelConfigList
+    plural: portchannelconfigs
+    shortNames:
+    - pccfg
+    singular: portchannelconfig
+  scope: Namespaced
+  versions:
+  - name: v1alpha1
+    schema:
+      openAPIV3Schema:
+        description: PortChannelConfig is the Schema for the NVE API
+        properties:
+          apiVersion:
+            description: |-
+              APIVersion defines the versioned schema of this representation of an object.
+              Servers should convert recognized schemas to the latest internal value, and
+              may reject unrecognized values.
+              More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
+            type: string
+          kind:
+            description: |-
+              Kind is a string value representing the REST resource this object represents.
+              Servers may infer this from the endpoint the client submits requests to.
+              Cannot be updated.
+              In CamelCase.
+              More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
+            type: string
+          metadata:
+            type: object
+          spec:
+            description: spec defines the desired state of NVE
+            properties:
+              vpcPeerLink:
+                default: false
+                description: VPCPeerLink indicates whether this PortChannel is part
+                  of the vPC peer link.
+                type: boolean
+            type: object
+        required:
+        - spec
+        type: object
+    served: true
+    storage: true

config/crd/bases/nx.cisco.networking.metal.ironcore.dev_portchannelconfigs.yaml

@@ -113,6 +113,7 @@ rules:
   - nx.cisco.networking.metal.ironcore.dev
   resources:
   - managementaccessconfigs
+  - portchannelconfigs
   verbs:
   - get
   - list

config/rbac/role.yaml

@@ -0,0 +1,10 @@
+apiVersion: nx.cisco.networking.metal.ironcore.dev/v1alpha1
+kind: PortChannelConfig
+metadata:
+  labels:
+    app.kubernetes.io/name: network-operator
+    app.kubernetes.io/managed-by: kustomize
+    networking.metal.ironcore.dev/device-name: leaf1
+  name: po1-cfg
+spec:
+  vpcPeerLink: true

config/samples/cisco/nx/v1alpha1_portchannelconfig.yaml

@@ -22,4 +22,5 @@ resources:
 - cisco/nx/v1alpha1_system.yaml
 - cisco/nx/v1alpha1_managementaccessconfig.yaml
 - cisco/nx/v1alpha1_vpcdomain.yaml
+- cisco/nx/v1alpha1_portchannelconfig.yaml
 # +kubebuilder:scaffold:manifestskustomizesamples