fix: VRF webhook validation path

Author: nikatza

api/core/v1alpha1/vrf_types.go

@@ -118,7 +118,7 @@ type VRFStatus struct {
 // +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
 
 // VRF is the Schema for the vrfs API
-// +kubebuilder:webhook:path=/validate-networking.metal.ironcore.dev-v1alpha1-vrf,mutating=false,failurePolicy=Fail,sideEffects=None,groups=networking.metal.ironcore.dev,resources=vrfs,verbs=create;update,versions=v1alpha1,name=vvrf.kb.io,admissionReviewVersions=v1
+// +kubebuilder:webhook:path=/validate-networking-metal-ironcore.dev-v1alpha1-vrf,mutating=false,failurePolicy=Fail,sideEffects=None,groups=networking.metal.ironcore.dev,resources=vrfs,verbs=create;update,versions=v1alpha1,name=vvrf.kb.io,admissionReviewVersions=v1
 type VRF struct {
 	metav1.TypeMeta   `json:",inline"`
 	metav1.ObjectMeta `json:"metadata,omitempty,omitzero"`

charts/network-operator/templates/webhook/webhooks.yaml

@@ -16,7 +16,7 @@ webhooks:
       service:
         name: network-operator-webhook-service
         namespace: {{ .Release.Namespace }}
-        path: /validate-networking.metal.ironcore.dev-v1alpha1-vrf
+        path: /validate-networking-metal-ironcore-dev-v1alpha1-vrf
     failurePolicy: Fail
     sideEffects: None
     admissionReviewVersions:

config/webhook/manifests.yaml

@@ -8,9 +8,9 @@ webhooks:
   - v1
   clientConfig:
     service:
-      name: webhook-service
-      namespace: system
-      path: /validate-networking.metal.ironcore.dev-v1alpha1-vrf
+      name: network-operator-webhook-service
+      namespace: network-operator-system
+      path: /validate-networking-metal-ironcore-dev-v1alpha1-vrf
   failurePolicy: Fail
   name: vrf-v1alpha1.kb.io
   rules:

config/webhook/service.yaml

@@ -5,6 +5,7 @@ metadata:
     app.kubernetes.io/name: network-operator
     app.kubernetes.io/managed-by: kustomize
   name: webhook-service
+  namespace: network-operator-system
 spec:
   ports:
     - port: 443

internal/webhook/core/v1alpha1/vrf_webhook.go

@@ -30,7 +30,7 @@ func SetupVRFWebhookWithManager(mgr ctrl.Manager) error {
 		Complete()
 }
 
-// +kubebuilder:webhook:path=/validate-networking.metal.ironcore.dev-v1alpha1-vrf,mutating=false,failurePolicy=Fail,sideEffects=None,groups=networking.metal.ironcore.dev,resources=vrfs,verbs=create;update,versions=v1alpha1,name=vrf-v1alpha1.kb.io,admissionReviewVersions=v1
+// +kubebuilder:webhook:path=/validate-networking-metal-ironcore-dev-v1alpha1-vrf,mutating=false,failurePolicy=Fail,sideEffects=None,groups=networking.metal.ironcore.dev,resources=vrfs,verbs=create;update,versions=v1alpha1,name=vrf-v1alpha1.kb.io,admissionReviewVersions=v1
 
 // VRFCustomValidator struct is responsible for validating the VRF resource
 // when it is created, updated, or deleted.
@@ -62,11 +62,6 @@ func (v *VRFCustomValidator) ValidateUpdate(_ context.Context, oldObj, newObj ru
 
 // ValidateDelete implements webhook.CustomValidator so a webhook will be registered for the type VRF.
 func (v *VRFCustomValidator) ValidateDelete(ctx context.Context, obj runtime.Object) (admission.Warnings, error) {
-	_, ok := obj.(*v1alpha1.VRF)
-	if !ok {
-		return nil, fmt.Errorf("expected a VRF object but got %T", obj)
-	}
-
 	return nil, nil
 }
 

internal/webhook/core/v1alpha1/vrf_webhook_test.go

@@ -130,19 +130,6 @@ var _ = Describe("VRF Webhook", func() {
 		})
 	})
 
-	Context("ValidateDelete", func() {
-		It("allows delete on VRF object", func() {
-			_, err := validator.ValidateDelete(ctx, obj)
-			Expect(err).ToNot(HaveOccurred())
-		})
-
-		It("rejects delete when object type is wrong", func() {
-			// Passing a different type (nil interface would panic so use something else)
-			_, err := validator.ValidateDelete(ctx, &v1alpha1.VRFList{})
-			Expect(err).To(HaveOccurred())
-		})
-	})
-
 	Context("ValidateCreate RouteTargets", func() {
 		It("accepts valid type-0 route target", func() {
 			obj.Spec.RouteTargets = []v1alpha1.RouteTarget{