Refactor clienutil package and housekeeping
#135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `List` call explicitly uses the `InNamespace` option, there is no need for using the `clientutil` package in this case.
In this situation is needless to use the `clientutil` as the namespace for the resource is always given explicitly be the `ISIS` resource which contains the `LocalObjectReferences`. Therefore using the client wrapper is not needed.
This patch changes the implementation of the `List` method on the k8s client wrapper implemented in the `clientutil` package to only add the `InNamespace` option for restricting to a certain namespace, if that option is not already provided to the function, honoring the callers intend.
hardikdr
added
the
area/metal-automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.