Commit 359b575
igor
memory/: scrub contextual leaks per the new public-fork lesson
Applied 'grep is necessary but not sufficient' to all five files in
linuxcnc/memory/ via human review (per the lesson added to
feedback_public_fork.md in the previous commit).
reference_fork_setup.md: clean. All content is fork-side build setup
or generic Linux/LinuxCNC knowledge.
reference_teleop_velocity_bug.md: scrubbed multiple contextual leaks.
- Symptom paragraph: removed 'With Z at HOME=500, re-homing after a
jog landed at ~498 mm' (private machine config — Z homing position
reveals downstream hardware) and 'Test 13 re-home consistency'
(private test name). Generalized to 'sub-millimeter tolerance' and
'millimeters of deviation'.
- Removed 'Why the test didn't catch this before' paragraph entirely.
It described 'Phase B of this branch' (private session phasing)
and the asymmetry between Z=0 (MIN_LIMIT) and Z=500 (MAX_LIMIT) —
both leak private hardware configuration. Replaced with a
generalized 'Why earlier tests miss this' explanation: symmetric
jog/home test setups coincidentally cancel the drift; only
asymmetric pairs surface it. Same lesson, no private leak.
- Removed 'How to verify' section entirely. It listed assertions in
test_logic.sh (Test 8b/8c, Tests 13/17/21, sim_lin_enc.so refs)
that are all private cncmill1 test infrastructure not present in
upstream LinuxCNC.
reference_upstream_pr_workflow.md: scrubbed two minor leaks.
- Tool intro: removed 'commit added on branch fizzy-forging-stardust'
(private session branch name from the upstream-pr-prep helper's
development history). The merge SHA stays — that's public on the
fork. Branch names that don't exist on the public fork after merge
are private context.
- Code block comment: changed '/tmp is tmpfs on this machine, override'
to 'override if /tmp is tmpfs on the host'. Removes the
work-computer-specific environmental detail.
Both files remain leak-free per a comprehensive grep including the
new contextual-leak terms (fizzy, stonebraker, Phase B, Test 13,
test_logic, HOME=500, sim_lin_enc) plus the original literal-path
patterns.
The five remaining linuxcnc/memory/ entries are now all fully
fork-relevant with no private project structure leaks:
- feedback_public_fork.md (public-fork hygiene rule + contextual-leak lesson)
- reference_fork_setup.md (fork build setup)
- reference_teleop_velocity_bug.md (upstream bug + fix description)
- reference_upstream_pr_workflow.md (upstream PR prep procedure)1 parent 4136478 commit 359b575
2 files changed
Lines changed: 12 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| |||
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
52 | 48 | | |
53 | 49 | | |
54 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
0 commit comments